Bug 218454 - Add back swap() free function for RefPtr
Summary: Add back swap() free function for RefPtr
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-02 12:52 PST by Saam Barati
Modified: 2020-11-05 15:04 PST (History)
6 users (show)

See Also:

Attachments
test EWS (575 bytes, patch)
2020-11-02 14:50 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
patch (1.39 KB, patch)
2020-11-05 11:32 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2020-11-02 12:52:25 PST 
See: https://bugs.webkit.org/show_bug.cgi?id=199866#c40 and Darin's response
Comment 1 Saam Barati 2020-11-02 12:53:40 PST 
Darin's possible solution here seems like a good starting point:
https://bugs.webkit.org/show_bug.cgi?id=199866#c42

Maybe we can also allow this for all PtrTraits, instead  of opting  some of them out
Comment 2 Saam Barati 2020-11-02 14:50:32 PST 
Created attachment 412974 [details]
test EWS

Let's see what EWS thinks
Comment 3 Saam Barati 2020-11-05 11:32:43 PST 
Created attachment 413334 [details]
patch
Comment 4 EWS 2020-11-05 15:03:21 PST 
Committed r269479: <https://trac.webkit.org/changeset/269479>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413334 [details].
Comment 5 Radar WebKit Bug Importer 2020-11-05 15:04:19 PST 
<rdar://problem/71096319>