Bug 218453 – libwebrtc.dylib relies on dead code stripping (fails to link if dead code is not stripped in Debug builds)

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[David Kilzer (:ddkilzer)]

libwebrtc.dylib relies on dead code stripping (fails to link if dead code is not stripped in Debug builds).

Found (rediscovered) while working on:

Bug 218315: WebKit should support building with variants other than debug and normal
<https://bugs.webkit.org/show_bug.cgi?id=218315>

See FIXME in Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig.

[youenn fablet]

What is the build instruction to trigger that issue?

[David Kilzer (:ddkilzer)]

(In reply to youenn fablet from comment #1)
> What is the build instruction to trigger that issue?

Rough steps to reproduce (I didn't try):

1. Apply patch from Bug 218315.

2. In Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig, change "DEAD_CODE_STRIPPING = YES" to "DEAD_CODE_STRIPPING = NO":

  // FIXME: Bug 218453: libwebrtc.dylib fails to link if this value is changed in libwebrtc.xcconfig or changed here for all targets.
- DEAD_CODE_STRIPPING = YES;
+ DEAD_CODE_STRIPPING = NO;

3. Build Release or Debug.  (I don't think it matters which if "DEAD_CODE_STRIPPING = NO" for both.)

[David Kilzer (:ddkilzer)]

(In reply to David Kilzer (:ddkilzer) from comment #2)
> (In reply to youenn fablet from comment #1)
> > What is the build instruction to trigger that issue?
> 
> Rough steps to reproduce (I didn't try):

Specifically, this is how I reproduced it while working on Bug 218315, but I did not try it again before posting this info.

[youenn fablet]

Thanks, we are probably missing some files that are only used by code that got stripped. Hopefully, we just need to compile this missing files.

[youenn fablet]

Created attachment 413144 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/71389632>

[youenn fablet]

Created attachment 414920 [details]
Patch

[youenn fablet]

Created attachment 414926 [details]
Patch

[youenn fablet]

Ping review

[EWS]

Committed r270305: <https://trac.webkit.org/changeset/270305>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414926 [details].

[David Kilzer (:ddkilzer)]

Thanks Youenn!