Bug 218452 - Duplicate copies of static RefPtr<Uint8Array> convertToUint8Array(IPC::SharedBufferCopy&& buffer) in RemoteLegacyCDMSession{Proxy}.cpp
Summary: Duplicate copies of static RefPtr<Uint8Array> convertToUint8Array(IPC::Shared...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-02 10:16 PST by David Kilzer (:ddkilzer)
Modified: 2020-11-10 17:02 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2020-11-02 10:16:54 PST 
static RefPtr<Uint8Array> convertToUint8Array(IPC::SharedBufferCopy&& buffer) in these two files:

Source/WebKit/GPUProcess/media/RemoteLegacyCDMSessionProxy.cpp
Source/WebKit/WebProcess/GPU/media/RemoteLegacyCDMSession.cpp

They even have slightly different implementations!

There may be other code that could be shared as well.

Found during a build fix for a patch on Bug 218315 (see <https://trac.webkit.org/r269251>).
Comment 1 Radar WebKit Bug Importer 2020-11-09 10:17:14 PST 
<rdar://problem/71198019>