Bug 218451 – [CMake] Add remote inspector platforms

• Status: RESOLVED
• Resolution: FIXED
• Component: CMake

[Don Olmstead]

Centralize the different remote inspector platform configs.

[Don Olmstead]

Created attachment 412935 [details]
Patch

[Don Olmstead]

Created attachment 412937 [details]
Patch

[Stephan Szabo]

Comment on attachment 412937 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412937&action=review

> Source/JavaScriptCore/PlatformJSCOnly.cmake:5
> +        include(inspector/remote/GLib.cmake)

It seems like this wouldn't end up with the same set of sources as before as the SourcesGTK.txt has more things (for example RemoteAutomationTarget.cpp). Is that okay?

[Don Olmstead]

(In reply to Stephan Szabo from comment #3)
> Comment on attachment 412937 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=412937&action=review
> 
> > Source/JavaScriptCore/PlatformJSCOnly.cmake:5
> > +        include(inspector/remote/GLib.cmake)
> 
> It seems like this wouldn't end up with the same set of sources as before as
> the SourcesGTK.txt has more things (for example RemoteAutomationTarget.cpp).
> Is that okay?

I'm not sure how well the JSCOnly with USE_GLIB is maintained. I don't think it would be an issue. Also not sure about JSCOnly on Cocoa and if there should be a Cocoa.cmake for it and Mac.

[Don Olmstead]

Created attachment 412948 [details]
Patch

Add a Cocoa platform definition for JSCOnly.

[EWS]

Committed r269309: <https://trac.webkit.org/changeset/269309>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412948 [details].

[Blaze Burg]

Comment on attachment 412948 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412948&action=review

> Source/JavaScriptCore/PlatformFTW.cmake:31
> +    include(inpsector/remote/Socket.cmake)

This looks incorrect (typo). How come EWS is all green, do we build FTW in CI somewhere?

[Don Olmstead]

(In reply to BJ Burg from comment #7)
> Comment on attachment 412948 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=412948&action=review
> 
> > Source/JavaScriptCore/PlatformFTW.cmake:31
> > +    include(inpsector/remote/Socket.cmake)
> 
> This looks incorrect (typo). How come EWS is all green, do we build FTW in
> CI somewhere?

Yea that's a typo. The FTW port doesn't build currently so I'll add that in there while fixing.