Bug 218451 - [CMake] Add remote inspector platforms
Summary: [CMake] Add remote inspector platforms
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-02 09:48 PST by Don Olmstead
Modified: 2021-01-26 12:58 PST (History)
15 users (show)

See Also:

Attachments
Patch (13.58 KB, patch)
2020-11-02 09:59 PST, Don Olmstead 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (13.58 KB, patch)
2020-11-02 10:05 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (16.23 KB, patch)
2020-11-02 11:06 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2020-11-02 09:48:00 PST 
Centralize the different remote inspector platform configs.
Comment 1 Don Olmstead 2020-11-02 09:59:58 PST Comment hidden (obsolete)
Comment 2 Don Olmstead 2020-11-02 10:05:07 PST 
Created attachment 412937 [details]
Patch
Comment 3 Stephan Szabo 2020-11-02 10:25:56 PST 
Comment on attachment 412937 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412937&action=review

> Source/JavaScriptCore/PlatformJSCOnly.cmake:5
> +        include(inspector/remote/GLib.cmake)

It seems like this wouldn't end up with the same set of sources as before as the SourcesGTK.txt has more things (for example RemoteAutomationTarget.cpp). Is that okay?
Comment 4 Don Olmstead 2020-11-02 10:34:57 PST 
(In reply to Stephan Szabo from comment #3)
> Comment on attachment 412937 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=412937&action=review
> 
> > Source/JavaScriptCore/PlatformJSCOnly.cmake:5
> > +        include(inspector/remote/GLib.cmake)
> 
> It seems like this wouldn't end up with the same set of sources as before as
> the SourcesGTK.txt has more things (for example RemoteAutomationTarget.cpp).
> Is that okay?

I'm not sure how well the JSCOnly with USE_GLIB is maintained. I don't think it would be an issue. Also not sure about JSCOnly on Cocoa and if there should be a Cocoa.cmake for it and Mac.
Comment 5 Don Olmstead 2020-11-02 11:06:54 PST 
Created attachment 412948 [details]
Patch

Add a Cocoa platform definition for JSCOnly.
Comment 6 EWS 2020-11-03 09:37:47 PST 
Committed r269309: <https://trac.webkit.org/changeset/269309>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412948 [details].
Comment 7 BJ Burg 2021-01-26 10:22:12 PST 
Comment on attachment 412948 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412948&action=review

> Source/JavaScriptCore/PlatformFTW.cmake:31
> +    include(inpsector/remote/Socket.cmake)

This looks incorrect (typo). How come EWS is all green, do we build FTW in CI somewhere?
Comment 8 Don Olmstead 2021-01-26 12:58:01 PST 
(In reply to BJ Burg from comment #7)
> Comment on attachment 412948 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=412948&action=review
> 
> > Source/JavaScriptCore/PlatformFTW.cmake:31
> > +    include(inpsector/remote/Socket.cmake)
> 
> This looks incorrect (typo). How come EWS is all green, do we build FTW in
> CI somewhere?

Yea that's a typo. The FTW port doesn't build currently so I'll add that in there while fixing.