Bug 218447 - [Testing] Match WebKitTestRunner and enable all "experimental" features in DumpRenderTree (cocoa)
Summary: [Testing] Match WebKitTestRunner and enable all "experimental" features in Du...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-02 08:56 PST by Sam Weinig
Modified: 2020-11-02 16:10 PST (History)
2 users (show)

See Also:

Attachments
Patch (3.32 KB, patch)
2020-11-02 09:01 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (6.86 KB, patch)
2020-11-02 09:58 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (7.12 KB, patch)
2020-11-02 10:43 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (7.94 KB, patch)
2020-11-02 10:59 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (12.72 KB, patch)
2020-11-02 11:53 PST, Sam Weinig 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (13.37 KB, patch)
2020-11-02 12:10 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (14.07 KB, patch)
2020-11-02 13:21 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-11-02 08:56:06 PST 
[Testing] Match WebKitTestRunner and enable all "experimental" features in DumpRenderTree (cocoa)
Comment 1 Sam Weinig 2020-11-02 09:01:15 PST Comment hidden (obsolete)
Comment 2 Sam Weinig 2020-11-02 09:58:54 PST Comment hidden (obsolete)
Comment 3 Sam Weinig 2020-11-02 10:43:19 PST Comment hidden (obsolete)
Comment 4 Sam Weinig 2020-11-02 10:59:35 PST Comment hidden (obsolete)
Comment 5 Sam Weinig 2020-11-02 11:53:28 PST Comment hidden (obsolete)
Comment 6 Sam Weinig 2020-11-02 12:10:16 PST 
Created attachment 412958 [details]
Patch
Comment 7 Sam Weinig 2020-11-02 13:21:52 PST 
Created attachment 412963 [details]
Patch
Comment 8 Darin Adler 2020-11-02 14:56:24 PST 
Comment on attachment 412963 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412963&action=review

> Tools/DumpRenderTree/mac/DumpRenderTree.mm:901
> +    [preferences setEncryptedMediaAPIEnabled:YES];
> +    [preferences setGamepadsEnabled:YES];
> +    [preferences setLinkPreloadEnabled:YES];
> +    [preferences setMediaPreloadingEnabled:YES];
> +    [preferences setColorFilterEnabled:YES];

What’s the significance of the ordering here? If there’s none, then I suggest sorting.
Comment 9 EWS 2020-11-02 16:05:25 PST 
Committed r269278: <https://trac.webkit.org/changeset/269278>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412963 [details].
Comment 10 Radar WebKit Bug Importer 2020-11-02 16:06:52 PST 
<rdar://problem/70970524>
Comment 11 Sam Weinig 2020-11-02 16:10:04 PST 
(In reply to Darin Adler from comment #8)
> Comment on attachment 412963 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=412963&action=review
> 
> > Tools/DumpRenderTree/mac/DumpRenderTree.mm:901
> > +    [preferences setEncryptedMediaAPIEnabled:YES];
> > +    [preferences setGamepadsEnabled:YES];
> > +    [preferences setLinkPreloadEnabled:YES];
> > +    [preferences setMediaPreloadingEnabled:YES];
> > +    [preferences setColorFilterEnabled:YES];
> 
> What’s the significance of the ordering here? If there’s none, then I
> suggest sorting.

There was none. Put a patch up to sort everything in the function at https://bugs.webkit.org/show_bug.cgi?id=218467.