Bug 218444 - [LFC][Integration] RenderText::absoluteQuadsForRange should use iterator
Summary: [LFC][Integration] RenderText::absoluteQuadsForRange should use iterator
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: InRadar
Depends on:
Reported: 2020-11-02 07:11 PST by Antti Koivisto
Modified: 2020-11-03 06:06 PST (History)
11 users (show)

See Also:

patch (16.25 KB, patch)
2020-11-02 07:20 PST, Antti Koivisto
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
patch (19.65 KB, patch)
2020-11-02 11:38 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2020-11-02 07:11:17 PST
It really should
Comment 1 Antti Koivisto 2020-11-02 07:20:42 PST
Created attachment 412916 [details]
Comment 2 Antti Koivisto 2020-11-02 11:38:58 PST
Created attachment 412950 [details]
Comment 3 zalan 2020-11-02 12:16:50 PST
Comment on attachment 412950 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=412950&action=review

> LayoutTests/ChangeLog:12
> +        On legacy path <br> y position is miscomputed affecting getBoundingClientRect().
> +        Update the test to match the new behavior. Results now match Firefox and Chrome.

Comment 4 EWS 2020-11-02 13:43:11 PST
Committed r269272: <https://trac.webkit.org/changeset/269272>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412950 [details].
Comment 5 Radar WebKit Bug Importer 2020-11-02 13:44:24 PST