Bug 218443 – [JSC] Remove compiler warning in LLIntData.cpp

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Xan Lopez]

This warning has been around in my machine for a while:

In file included from DerivedSources/ForwardingHeaders/wtf/StdLibExtras.h:32,
                 from DerivedSources/ForwardingHeaders/wtf/FastMalloc.h:26,
                 from ../../Source/JavaScriptCore/config.h:38,
                 from ../../Source/JavaScriptCore/llint/LLIntCLoop.cpp:26,
                 from DerivedSources/JavaScriptCore/unified-sources/UnifiedSource-6e4525b9-1.cpp:1:
../../Source/JavaScriptCore/llint/LLIntData.cpp: In static member function ‘static void JSC::LLInt::Data::performAssertions(JSC::VM&)’:
../../Source/JavaScriptCore/llint/LLIntData.cpp:100:88: warning: comparison of integer expressions of different signedness: ‘long unsigned int’ and ‘ptrdiff_t’ {aka ‘long int’} [-Wsign-compare]
  100 |     ASSERT(static_cast<long unsigned int>(CallFrameSlot::codeBlock * sizeof(Register)) == CallFrame::returnPCOffset() + MachineRegisterSize);
      |            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
DerivedSources/ForwardingHeaders/wtf/Assertions.h:346:11: note: in definition of macro ‘ASSERT’
  346 |     if (!(assertion)) { \
      |           ^~~~~~~~~


This seems fixable by casting the scoped enum used in this comparison (CallFrameSlot) to its underlying type, which seems advised in this kind of operation anyway. Also while at it I removed the type annotation for the enum, since we are using the default.

[Xan Lopez]

Created attachment 412915 [details]
Remove warning from LLIntData

v1

[Radar WebKit Bug Importer]

<rdar://problem/70955212>

[Mark Lam]

Comment on attachment 412915 [details]
Remove warning from LLIntData

r=me

[EWS]

Committed r269252: <https://trac.webkit.org/changeset/269252>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412915 [details].