Bug 218442 – Allow low latency H264 encoder in GPUProcess

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

Allow low latency H264 encoder in GPUProcess

[youenn fablet]

Created attachment 412909 [details]
Patch

[youenn fablet]

Created attachment 412914 [details]
Patch

[Eric Carlson]

Comment on attachment 412914 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412914&action=review

> Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.mm:97
> +- (void)setLowLatency:(bool)isLowLatencyEnabled {

Nit: "isLowLatencyEnabled" sounds like a question, I would probably call the parameter "lowLatencyEnabled", or even just "enabled"

> Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.mm:99
> +        return [m_h264Encoder setH264LowLatencyEncoderEnabled:isLowLatencyEnabled];

Nit: "return" is unnecessary

> Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.mm:319
> +void setLocalEncoderLowLatency(LocalEncoder localEncoder, bool isLowLatencyEnabled)

Ditto about the parameter name from above.

[youenn fablet]

Created attachment 413032 [details]
Patch for landing

[EWS]

ChangeLog entry in Source/ThirdParty/libwebrtc/ChangeLog contains OOPS!.

[youenn fablet]

Created attachment 413039 [details]
Patch for landing

[EWS]

Committed r269293: <https://trac.webkit.org/changeset/269293>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413039 [details].

[Radar WebKit Bug Importer]

<rdar://problem/70989701>