Bug 218442 - Allow low latency H264 encoder in GPUProcess
Summary: Allow low latency H264 encoder in GPUProcess
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks: 218445
  Show dependency tree / graph
 
Reported: 2020-11-02 05:56 PST by youenn fablet
Modified: 2020-11-03 04:34 PST (History)
10 users (show)

See Also:

Attachments
Patch (37.85 KB, patch)
2020-11-02 06:01 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (37.92 KB, patch)
2020-11-02 06:37 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (37.91 KB, patch)
2020-11-03 03:19 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (37.91 KB, patch)
2020-11-03 03:57 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-11-02 05:56:04 PST 
Allow low latency H264 encoder in GPUProcess
Comment 1 youenn fablet 2020-11-02 06:01:50 PST 
Created attachment 412909 [details]
Patch
Comment 2 youenn fablet 2020-11-02 06:37:55 PST 
Created attachment 412914 [details]
Patch
Comment 3 Eric Carlson 2020-11-02 14:03:58 PST 
Comment on attachment 412914 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412914&action=review

> Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.mm:97
> +- (void)setLowLatency:(bool)isLowLatencyEnabled {

Nit: "isLowLatencyEnabled" sounds like a question, I would probably call the parameter "lowLatencyEnabled", or even just "enabled"

> Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.mm:99
> +        return [m_h264Encoder setH264LowLatencyEncoderEnabled:isLowLatencyEnabled];

Nit: "return" is unnecessary

> Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.mm:319
> +void setLocalEncoderLowLatency(LocalEncoder localEncoder, bool isLowLatencyEnabled)

Ditto about the parameter name from above.
Comment 4 youenn fablet 2020-11-03 03:19:15 PST 
Created attachment 413032 [details]
Patch for landing
Comment 5 EWS 2020-11-03 03:55:39 PST 
ChangeLog entry in Source/ThirdParty/libwebrtc/ChangeLog contains OOPS!.
Comment 6 youenn fablet 2020-11-03 03:57:52 PST 
Created attachment 413039 [details]
Patch for landing
Comment 7 EWS 2020-11-03 04:33:08 PST 
Committed r269293: <https://trac.webkit.org/changeset/269293>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413039 [details].
Comment 8 Radar WebKit Bug Importer 2020-11-03 04:34:19 PST 
<rdar://problem/70989701>