Bug 218440 – Use FileDownload to fetch built product from master

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Angelos Oikonomopoulos]

Use FileDownload to fetch built product from master

[Angelos Oikonomopoulos]

Created attachment 412907 [details]
Patch

[Aakash Jain]

unit-tests in TestDownloadBuiltProductFromMaster would need to be updated, it would become similar to TestUploadBuiltProduct.

[Angelos Oikonomopoulos]

Created attachment 413160 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/71187403>

[Aakash Jain]

Comment on attachment 413160 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413160&action=review

Patch looks good. various minor comments.

Also you can remove EWS_BUILD_URL variable, it's unused after this patch.

> Tools/CISupport/ews-build/steps.py:2443
> +class DownloadBuiltProductFromMaster(transfer.FileDownload):

Please add step name, e.g.:
name = 'download-built-product-from-master'

> Tools/CISupport/ews-build/steps.py:2458
>      def getResultSummary(self):

Nit: missing empty line before method.

> Tools/CISupport/ews-build/steps_unittest.py:211
> +def downloadFileRecordingContents(recorder):

Maybe it's better to keep this method inside TestDownloadBuiltProductFromMaster class since it's used only there.

> Tools/CISupport/ews-build/steps_unittest.py:2601
> +        self.setupStep(step)

Can write this as one line:
self.setupStep(DownloadBuiltProductFromMaster(mastersrc=__file__))

> Tools/CISupport/ews-build/steps_unittest.py:2621
> +        buf = b''.join(buf)

is 'b' required in b''?

> Tools/CISupport/ews-build/steps_unittest.py:2622
> +        self.assertEqual(len(buf), 1000)

Can store this 1000 in a variable and re-use that variable.

> Tools/CISupport/ews-build/steps_unittest.py:2623
> +        with open(__file__, 'rb') as mf:

can improve the variable name for 'mf'

[Angelos Oikonomopoulos]

Created attachment 413818 [details]
Patch

[EWS]

Committed r269683: <https://trac.webkit.org/changeset/269683>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413818 [details].