Use FileDownload to fetch built product from master
Created attachment 412907 [details]
unit-tests in TestDownloadBuiltProductFromMaster would need to be updated, it would become similar to TestUploadBuiltProduct.
Created attachment 413160 [details]
Comment on attachment 413160 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=413160&action=review
Patch looks good. various minor comments.
Also you can remove EWS_BUILD_URL variable, it's unused after this patch.
> +class DownloadBuiltProductFromMaster(transfer.FileDownload):
Please add step name, e.g.:
name = 'download-built-product-from-master'
> def getResultSummary(self):
Nit: missing empty line before method.
> +def downloadFileRecordingContents(recorder):
Maybe it's better to keep this method inside TestDownloadBuiltProductFromMaster class since it's used only there.
> + self.setupStep(step)
Can write this as one line:
> + buf = b''.join(buf)
is 'b' required in b''?
> + self.assertEqual(len(buf), 1000)
Can store this 1000 in a variable and re-use that variable.
> + with open(__file__, 'rb') as mf:
can improve the variable name for 'mf'
Created attachment 413818 [details]
Committed r269683: <https://trac.webkit.org/changeset/269683>
All reviewed patches have been landed. Closing bug and clearing flags on attachment 413818 [details].