Bug 218408 - Usage of allWorkletGlobalScopesSet() in WorkletGlobalScope is not thread-safe
Summary: Usage of allWorkletGlobalScopesSet() in WorkletGlobalScope is not thread-safe
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-30 17:06 PDT by Chris Dumez
Modified: 2020-10-30 23:53 PDT (History)
7 users (show)

See Also:

Attachments
Patch (5.43 KB, patch)
2020-10-30 17:13 PDT, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (5.53 KB, patch)
2020-10-30 17:15 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (5.53 KB, patch)
2020-10-30 23:07 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-10-30 17:06:46 PDT 
Usage of allWorkletGlobalScopesSet() in WorkletGlobalScope is not thread-safe.
Comment 1 Chris Dumez 2020-10-30 17:13:00 PDT 
Created attachment 412818 [details]
Patch
Comment 2 Chris Dumez 2020-10-30 17:15:05 PDT 
Created attachment 412819 [details]
Patch
Comment 3 Geoffrey Garen 2020-10-30 19:08:48 PDT 
Comment on attachment 412819 [details]
Patch

r=me
Comment 4 EWS 2020-10-30 22:32:12 PDT 
Found 2 new test failures: fast/css-custom-paint/constructor.html, fast/css-custom-paint/leaks.html
Comment 5 Chris Dumez 2020-10-30 23:07:53 PDT 
Created attachment 412833 [details]
Patch
Comment 6 EWS 2020-10-30 23:52:41 PDT 
Committed r269221: <https://trac.webkit.org/changeset/269221>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412833 [details].
Comment 7 Radar WebKit Bug Importer 2020-10-30 23:53:20 PDT 
<rdar://problem/70910590>