Bug 218407 - [webkit-patch] Append identifier to commit message
Summary: [webkit-patch] Append identifier to commit message
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
Keywords: InRadar
Depends on:
Reported: 2020-10-30 16:30 PDT by Jonathan Bedard
Modified: 2020-11-04 16:03 PST (History)
6 users (show)

See Also:

Patch (29.93 KB, patch)
2020-10-30 16:36 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch (30.10 KB, patch)
2020-11-02 14:02 PST, Jonathan Bedard
jbedard: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-10-30 16:30:24 PDT
We need to append the identifier to the commit message so that identifiers are present in places which do not natively support them.
Comment 1 Radar WebKit Bug Importer 2020-10-30 16:30:42 PDT
Comment 2 Jonathan Bedard 2020-10-30 16:36:53 PDT
Created attachment 412809 [details]
Comment 3 Jonathan Bedard 2020-10-30 17:52:29 PDT
I think we probably want to override 'trunk' and make it 'main' to prepare for our new Git-only world, I'm also not certain if we want this at the beginning or end of the commit message. I did the end of the commit message (like git-svn and Chromium do), but that is less accessible than making it the 2nd line of the commit message.

The worst part about all of this is that once we make this decision, we really don't want to back-track on it.
Comment 4 Jonathan Bedard 2020-11-02 14:02:35 PST
Created attachment 412968 [details]
Comment 5 Jonathan Bedard 2020-11-04 14:13:42 PST
Probably need to do this from commit-log-editor, but I'm still not entirely sure how this script works, because it requires being passed a ChangeLog to function.
Comment 6 Jonathan Bedard 2020-11-04 16:03:35 PST
Comment on attachment 412968 [details]

Was really trying to avoid doing this server-side, because I'm pretty sure we will end up needing to it after the commit has already happened (ie, edit the changelog after a commit has occurred)

I'm not super excited about doing editing commit messages right after the commit has happened, but that might be the best solution.