NEW 218407
[webkit-patch] Append identifier to commit message 
https://bugs.webkit.org/show_bug.cgi?id=218407
Summary [webkit-patch] Append identifier to commit message
Jonathan Bedard
Reported 2020-10-30 16:30:24 PDT
We need to append the identifier to the commit message so that identifiers are present in places which do not natively support them.
Attachments
Patch (29.93 KB, patch)
2020-10-30 16:36 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (30.10 KB, patch)
2020-11-02 14:02 PST, Jonathan Bedard 		jbedard: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-10-30 16:30:42 PDT
<rdar://problem/70902230>
Jonathan Bedard
Comment 2 2020-10-30 16:36:53 PDT
Created attachment 412809 [details] Patch
Jonathan Bedard
Comment 3 2020-10-30 17:52:29 PDT
I think we probably want to override 'trunk' and make it 'main' to prepare for our new Git-only world, I'm also not certain if we want this at the beginning or end of the commit message. I did the end of the commit message (like git-svn and Chromium do), but that is less accessible than making it the 2nd line of the commit message. The worst part about all of this is that once we make this decision, we really don't want to back-track on it.
Jonathan Bedard
Comment 4 2020-11-02 14:02:35 PST
Created attachment 412968 [details] Patch
Jonathan Bedard
Comment 5 2020-11-04 14:13:42 PST
Probably need to do this from commit-log-editor, but I'm still not entirely sure how this script works, because it requires being passed a ChangeLog to function.
Jonathan Bedard
Comment 6 2020-11-04 16:03:35 PST
Comment on attachment 412968 [details] Patch Was really trying to avoid doing this server-side, because I'm pretty sure we will end up needing to it after the commit has already happened (ie, edit the changelog after a commit has occurred) I'm not super excited about doing editing commit messages right after the commit has happened, but that might be the best solution.
Note You need to log in before you can comment on or make changes to this bug.