Bug 218382 - WebDriver: session can have more than one active input source of the same type
Summary: WebDriver: session can have more than one active input source of the same type
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebDriver (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: gtk-webdriver
  Show dependency tree / graph
 
Reported: 2020-10-30 06:47 PDT by Carlos Garcia Campos
Modified: 2020-11-05 00:46 PST (History)
2 users (show)

See Also:

Attachments
Patch (17.37 KB, patch)
2020-10-30 06:54 PDT, Carlos Garcia Campos 		bburg: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2020-10-30 06:47:55 PDT 
We are failing in that case, and the dispatcher assumes it's not possible, but the spec doesn't say there's such limitation and there's a WPT infrastructure test checking that (infrastructure/testdriver/actions/eventOrder.html).
Comment 1 Carlos Garcia Campos 2020-10-30 06:54:55 PDT 
Created attachment 412737 [details]
Patch
Comment 2 BJ Burg 2020-11-04 11:41:15 PST 
Comment on attachment 412737 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412737&action=review

r=me, good catch.

> Source/WebDriver/ChangeLog:8
> +        Only send to the browser the list of input sources actually used by the action sequence.

I checked, and this is indeed what safaridriver already does on its side.
Comment 3 Carlos Garcia Campos 2020-11-05 00:45:54 PST 
Committed r269419: <https://trac.webkit.org/changeset/269419>
Comment 4 Radar WebKit Bug Importer 2020-11-05 00:46:23 PST 
<rdar://problem/71069264>