Bug 218374 - Convert ScrollingTreeNode change flags to an OptionSet<>
Summary: Convert ScrollingTreeNode change flags to an OptionSet<>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-29 22:23 PDT by Simon Fraser (smfr)
Modified: 2020-10-30 07:00 PDT (History)
11 users (show)

See Also:

Attachments
Patch (143.37 KB, patch)
2020-10-29 22:23 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (154.19 KB, patch)
2020-10-29 22:32 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-10-29 22:23:00 PDT 
Convert ScrollingTreeNode change flags to an OptionSet<>
Comment 1 Simon Fraser (smfr) 2020-10-29 22:23:55 PDT 
Created attachment 412713 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-10-29 22:32:00 PDT 
Created attachment 412715 [details]
Patch
Comment 3 Antti Koivisto 2020-10-29 22:37:02 PDT 
Comment on attachment 412715 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412715&action=review

> Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:110
> +template<> struct EnumTraits<WebCore::ScrollingStateNode::Property> {
> +    using values = EnumValues<
> +        WebCore::ScrollingStateNode::Property,
> +        WebCore::ScrollingStateNode::Property::Layer,
> +        WebCore::ScrollingStateNode::Property::ChildNodes,
> +        WebCore::ScrollingStateNode::Property::ScrollableAreaSize,

Sad that this thing has to list all values again. Does it at least fail at compile time if you miss something?
Comment 4 Simon Fraser (smfr) 2020-10-29 22:57:14 PDT 
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 412715 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=412715&action=review
> 
> > Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:110
> > +template<> struct EnumTraits<WebCore::ScrollingStateNode::Property> {
> > +    using values = EnumValues<
> > +        WebCore::ScrollingStateNode::Property,
> > +        WebCore::ScrollingStateNode::Property::Layer,
> > +        WebCore::ScrollingStateNode::Property::ChildNodes,
> > +        WebCore::ScrollingStateNode::Property::ScrollableAreaSize,
> 
> Sad that this thing has to list all values again. Does it at least fail at
> compile time if you miss something?

It does compile but I assume IPC decoding would throw a failure at runtime. Not ideal.
Comment 5 EWS 2020-10-30 06:59:26 PDT 
Committed r269184: <https://trac.webkit.org/changeset/269184>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412715 [details].
Comment 6 Radar WebKit Bug Importer 2020-10-30 07:00:25 PDT 
<rdar://problem/70873217>