Bug 218373 - Remove all remaining testRunner.overridePreference calls
Summary: Remove all remaining testRunner.overridePreference calls
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-29 20:49 PDT by Sam Weinig
Modified: 2020-11-01 11:57 PST (History)
7 users (show)

See Also:

Attachments
Patch (20.83 KB, patch)
2020-10-29 20:55 PDT, Sam Weinig 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (20.84 KB, patch)
2020-10-29 21:04 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (21.43 KB, patch)
2020-10-30 08:06 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (20.80 KB, patch)
2020-10-30 09:31 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (20.59 KB, patch)
2020-10-30 12:08 PDT, Sam Weinig 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (25.10 KB, patch)
2020-10-30 17:03 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-10-29 20:49:28 PDT 
Remove all remaining testRunner.overridePreference calls
Comment 1 Sam Weinig 2020-10-29 20:55:02 PDT Comment hidden (obsolete)
Comment 2 Sam Weinig 2020-10-29 21:04:26 PDT Comment hidden (obsolete)
Comment 3 Sam Weinig 2020-10-30 08:06:31 PDT Comment hidden (obsolete)
Comment 4 EWS Watchlist 2020-10-30 08:13:04 PDT Comment hidden (obsolete)
Comment 5 Sam Weinig 2020-10-30 09:31:07 PDT Comment hidden (obsolete)
Comment 6 Sam Weinig 2020-10-30 12:08:12 PDT 
Created attachment 412785 [details]
Patch
Comment 7 Sam Weinig 2020-10-30 17:03:33 PDT 
Created attachment 412813 [details]
Patch
Comment 8 Sam Weinig 2020-10-30 19:36:06 PDT 
Ok. Should be good to go now if anyone wants to review.
Comment 9 EWS 2020-10-31 09:08:55 PDT 
Committed r269226: <https://trac.webkit.org/changeset/269226>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412813 [details].
Comment 10 Radar WebKit Bug Importer 2020-10-31 09:09:25 PDT 
<rdar://problem/70916397>
Comment 11 Darin Adler 2020-11-01 11:57:46 PST 
Comment on attachment 412813 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412813&action=review

Forgot to push "publish" when I wrote this comment!

> LayoutTests/ChangeLog:46
> +2020-10-29  Sam Weinig  <weinig@apple.com>
> +
> +
> +        * fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html:
> +        * fast/parser/noscript-with-javascript-disabled.html:
> +        * fast/text/international/locale-sensitive-fonts.html:
> +        * fast/text/zero-font-size.html:
> +        * http/tests/download/default-encoding.html:
> +        * http/tests/misc/favicon-loads-with-images-disabled.html:
> +        * http/tests/security/cross-origin-local-storage-wk1.html:
> +        * http/tests/security/resources/load-local-storage.html:
> +        * http/tests/xsl/xslt-transform-with-javascript-disabled.html:
> +        * platform/win/inverted-colors/non-composited.html:
> +        * platform/wk2/TestExpectations:
> +        * svg/as-image/svg-image-with-data-uri-images-disabled.html:

Oops, extra change log stuff here.