Bug 21836 - REGRESSION: Sign-in on Fancast.com causes crash in Webkit nightly
Summary: REGRESSION: Sign-in on Fancast.com causes crash in Webkit nightly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: XML (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P1 Normal
Assignee: Alexey Proskuryakov
URL: http://www.fancast.com/
Keywords: Regression
Depends on:
Blocks:
 
Reported: 2008-10-23 13:21 PDT by Stuart A. Malone
Modified: 2008-10-27 08:28 PDT (History)
1 user (show)

See Also:

Attachments
Crash log (25.75 KB, text/plain)
2008-10-23 13:23 PDT, Stuart A. Malone 		no flags Details
proposed fix (5.11 KB, patch)
2008-10-24 00:53 PDT, Alexey Proskuryakov 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stuart A. Malone 2008-10-23 13:21:43 PDT 
I'm having a repeatable crash in Webkit nightly build r37790 on the fancast.com website.

I go to their home page, click the SIGN ON link and enter my username and password. When I click the SUBMIT button, I get a beachball for about 10 seconds and then Safari crashes.

The crash does not occur in the release build of Safari 3.1.2 (5525.20.1).

I normally use Safari AdBlock, but I disabled it and the crash still occurs.

I have a crash log and will attach it to the bug report.
Comment 1 Stuart A. Malone 2008-10-23 13:23:33 PDT 
Created attachment 24611 [details]
Crash log
Comment 2 Alexey Proskuryakov 2008-10-23 13:36:09 PDT 
Confirmed with a local debug build. Stack trace:

#0	0x032d7393 in JSC::JSGlobalObject::d at JSGlobalObject.h:252
#1	0x038d0f49 in JSC::JSGlobalObject::globalData at JSGlobalObject.h:251
#2	0x038caac3 in WebCore::XMLHttpRequest::dropProtection at XMLHttpRequest.cpp:832
#3	0x038cef0f in WebCore::XMLHttpRequest::didFinishLoading at XMLHttpRequest.cpp:1042
#4	0x0389e955 in WebCore::SubresourceLoader::didFinishLoading at SubresourceLoader.cpp:194
#5	0x037c7626 in WebCore::ResourceLoader::didFinishLoading at ResourceLoader.cpp:398
#6	0x037c513a in -[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:] at ResourceHandleMac.mm:560

I'm going to take a look.
Comment 3 Alexey Proskuryakov 2008-10-24 00:53:35 PDT 
Created attachment 24636 [details]
proposed fix
Comment 4 Darin Adler 2008-10-24 10:39:34 PDT 
Comment on attachment 24636 [details]
proposed fix

r=me
Comment 5 Alexey Proskuryakov 2008-10-24 16:39:43 PDT 
Committed revision 37874.
Comment 6 Stuart A. Malone 2008-10-27 08:28:03 PDT 
Thank you. I downloaded WebKit-SVN-r37894.dmg and confirmed that the bug is fixed.