Bug 21836 – REGRESSION: Sign-in on Fancast.com causes crash in Webkit nightly

• Status: RESOLVED
• Resolution: FIXED
• Component: XML

[Stuart A. Malone]

I'm having a repeatable crash in Webkit nightly build r37790 on the fancast.com website.

I go to their home page, click the SIGN ON link and enter my username and password. When I click the SUBMIT button, I get a beachball for about 10 seconds and then Safari crashes.

The crash does not occur in the release build of Safari 3.1.2 (5525.20.1).

I normally use Safari AdBlock, but I disabled it and the crash still occurs.

I have a crash log and will attach it to the bug report.

[Stuart A. Malone]

Created attachment 24611 [details]
Crash log

[Alexey Proskuryakov]

Confirmed with a local debug build. Stack trace:

#0	0x032d7393 in JSC::JSGlobalObject::d at JSGlobalObject.h:252
#1	0x038d0f49 in JSC::JSGlobalObject::globalData at JSGlobalObject.h:251
#2	0x038caac3 in WebCore::XMLHttpRequest::dropProtection at XMLHttpRequest.cpp:832
#3	0x038cef0f in WebCore::XMLHttpRequest::didFinishLoading at XMLHttpRequest.cpp:1042
#4	0x0389e955 in WebCore::SubresourceLoader::didFinishLoading at SubresourceLoader.cpp:194
#5	0x037c7626 in WebCore::ResourceLoader::didFinishLoading at ResourceLoader.cpp:398
#6	0x037c513a in -[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:] at ResourceHandleMac.mm:560

I'm going to take a look.

[Alexey Proskuryakov]

Created attachment 24636 [details]
proposed fix

[Darin Adler]

Comment on attachment 24636 [details]
proposed fix

r=me

[Alexey Proskuryakov]

Committed revision 37874.

[Stuart A. Malone]

Thank you. I downloaded WebKit-SVN-r37894.dmg and confirmed that the bug is fixed.