Bug 218358 – [GLIB] REGRESSION(r269144) imported/w3c/web-platform-tests/css/cssom-view/scrollIntoView-scrollMargin.html is failing

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Lauro Moura]

imported/w3c/web-platform-tests/css/cssom-view/scrollIntoView-scrollMargin.html

r269144 updated the expectations but the test is still giving the old results, both in the bots and locally.

Diff:

--- /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/css/cssom-view/scrollIntoView-scrollMargin-expected.txt
+++ /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/css/cssom-view/scrollIntoView-scrollMargin-actual.txt
@@ -1,5 +1,5 @@
 
-PASS scrollIntoView({block: "center", inline: "center"})
-PASS scrollIntoView({block: "start", inline: "start"})
-PASS scrollIntoView({block: "end", inline: "end"})
+FAIL scrollIntoView({block: "center", inline: "center"}) assert_approx_equals: scrollX expected 153.5 +/- 0.5 but got 158
+FAIL scrollIntoView({block: "start", inline: "start"}) assert_approx_equals: scrollX expected 184 +/- 0.5 but got 200
+FAIL scrollIntoView({block: "end", inline: "end"}) assert_approx_equals: scrollX expected 123 +/- 0.5 but got 115

[Lauro Moura]

Gardened in r269172

[Martin Robinson]

Created attachment 412727 [details]
Patch

[Martin Robinson]

It seems that I did not fully expose scroll-margin when ENABLE_SCROLL_SNAP was disabled. I believe that this patch fixes the issue.

[Lauro Moura]

(In reply to Martin Robinson from comment #3)
> It seems that I did not fully expose scroll-margin when ENABLE_SCROLL_SNAP
> was disabled. I believe that this patch fixes the issue.

Tested the patch with the css-om suite and indeed it fixes the issue with no regressions.

Thanks!

[EWS]

Committed r269246: <https://trac.webkit.org/changeset/269246>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412727 [details].

[Radar WebKit Bug Importer]

<rdar://problem/70948378>