Bug 218355 - Remove all remaining boolean overridePreference calls
Summary: Remove all remaining boolean overridePreference calls
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-29 14:06 PDT by Sam Weinig
Modified: 2020-10-29 18:18 PDT (History)
8 users (show)

See Also:

Attachments
Patch (28.94 KB, patch)
2020-10-29 14:25 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (30.47 KB, patch)
2020-10-29 15:40 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-10-29 14:06:58 PDT 
Remove all remaining boolean overridePreference calls
Comment 1 Sam Weinig 2020-10-29 14:25:51 PDT 
Created attachment 412686 [details]
Patch
Comment 2 Sam Weinig 2020-10-29 15:40:02 PDT 
Created attachment 412695 [details]
Patch
Comment 3 Darin Adler 2020-10-29 15:46:34 PDT 
Comment on attachment 412695 [details]
Patch

A lot of unneeded "window." prefixes in these tests. Once we know we’re running in a test runner, then "internals" works, and we don’t need "window.internals".
Comment 4 EWS 2020-10-29 18:17:34 PDT 
Committed r269176: <https://trac.webkit.org/changeset/269176>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412695 [details].
Comment 5 Radar WebKit Bug Importer 2020-10-29 18:18:22 PDT 
<rdar://problem/70837130>