Bug 218328 – Add some logging to SequenceCheckerImpl::IsCurrent

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

Add some logging to SequenceCheckerImpl::IsCurrent

[youenn fablet]

Created attachment 412629 [details]
Patch

[Eric Carlson]

Comment on attachment 412629 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412629&action=review

> Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/synchronization/sequence_checker.cc:63
> +    if (valid_queue_ != current_queue)
> +      RTC_LOG(LS_ERROR) << "SequenceCheckerImpl queue check is failing";
>      return valid_queue_ == current_queue;
>    }
>    if (valid_system_queue_ && valid_system_queue_ == current_system_queue) {
> +    if (valid_queue_ != current_queue)
> +      RTC_LOG(LS_ERROR) << "SequenceCheckerImpl system queue check is failing";
>      return true;
>    }
> -  return rtc::IsThreadRefEqual(valid_thread_, current_thread);
> +  auto result = rtc::IsThreadRefEqual(valid_thread_, current_thread);
> +  if (!result)
> +    RTC_LOG(LS_ERROR) << "SequenceCheckerImpl thread check is failing";

Would it be helpful have unique log strings to help identify which check fails?

[youenn fablet]

> Would it be helpful have unique log strings to help identify which check
> fails?

These strings are each different so we should know which one is failing.

[EWS]

Committed r269156: <https://trac.webkit.org/changeset/269156>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412629 [details].

[Radar WebKit Bug Importer]

<rdar://problem/70817257>