Bug 21831 - Fix create_hash_table for Perl 5.10
Summary: Fix create_hash_table for Perl 5.10
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL: https://lists.webkit.org/pipermail/we...
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-23 11:10 PDT by David Kilzer (:ddkilzer)
Modified: 2008-10-23 13:31 PDT (History)
0 users

See Also:


Attachments
Patch v1 (1.53 KB, patch)
2008-10-23 11:16 PDT, David Kilzer (:ddkilzer)
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2008-10-23 11:10:03 PDT
Square brackets need to be escaped in a print() statement to make Perl 5.10 happy when running create_hash_table.  Patch forthcoming.
Comment 1 David Kilzer (:ddkilzer) 2008-10-23 11:16:23 PDT
Created attachment 24603 [details]
Patch v1

Just fix it.
Comment 2 Sam Weinig 2008-10-23 11:18:16 PDT
Comment on attachment 24603 [details]
Patch v1

> commit 9ad34c84b18ab388ac50ad70fe7aac879ad74f6d
> Author: David Kilzer <ddkilzer@apple.com>
> Date:   Thu Oct 23 11:16:14 2008 -0700
> 
>             Bug 21831: Fix create_hash_table for Perl 5.10
>     
>             <https://bugs.webkit.org/show_bug.cgi?id=21831>
>     
>             Reviewed by NOBODY (OOPS!).
>     
>             * kjs/create_hash_table: Escaped square brackets so that Perl 5.10
>             doesn't try to use @nameEntries.
> 
> diff --git a/JavaScriptCore/ChangeLog b/JavaScriptCore/ChangeLog
> index 3fbfd0c..50742fd 100644
> --- a/JavaScriptCore/ChangeLog
> +++ b/JavaScriptCore/ChangeLog
> @@ -1,3 +1,14 @@
> +2008-10-23  David Kilzer  <ddkilzer@apple.com>
> +
> +        Bug 21831: Fix create_hash_table for Perl 5.10
> +
> +        <https://bugs.webkit.org/show_bug.cgi?id=21831>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * kjs/create_hash_table: Escaped square brackets so that Perl 5.10
> +        doesn't try to use @nameEntries.
> +
>  2008-10-22  Darin Adler  <darin@apple.com>
>  
>          Reviewed by Sam Weinig.
> diff --git a/JavaScriptCore/kjs/create_hash_table b/JavaScriptCore/kjs/create_hash_table
> index d98cc30..829a024 100755
> --- a/JavaScriptCore/kjs/create_hash_table
> +++ b/JavaScriptCore/kjs/create_hash_table
> @@ -215,7 +215,7 @@ sub output() {
>          print "\nnamespace JSC {\n";
>      }
>      my $count = scalar @keys + 1;
> -    print "\nstatic const struct HashTableValue ${nameEntries}[$count] = {\n";
> +    print "\nstatic const struct HashTableValue ${nameEntries}\[$count\] = {\n";
>      my $i = 0;
>      foreach my $key (@keys) {
>          my $firstValue = "";
Comment 3 David Kilzer (:ddkilzer) 2008-10-23 13:31:26 PDT
Committed r37819

http://trac.webkit.org/changeset/37819