Bug 218308 – Resync web-platform-tests/payment-request tests from upstream

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Chris Dumez]

Resync web-platform-tests/payment-request tests from upstream.

[Chris Dumez]

Created attachment 412576 [details]
Patch

[Chris Dumez]

Created attachment 412652 [details]
Patch

[Geoffrey Garen]

Comment on attachment 412652 [details]
Patch

rs=me

[Chris Dumez]

Created attachment 412677 [details]
Patch

[Chris Dumez]

Comment on attachment 412677 [details]
Patch

Clearing flags on attachment: 412677

Committed r269164: <https://trac.webkit.org/changeset/269164>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/70822990>

[Truitt Savell]

imported/w3c/web-platform-tests/payment-request/show-method-optional-promise-rejects.https.html

is a flaky failure after its move.



 Diff:
--- /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/payment-request/show-method-optional-promise-rejects.https-expected.txt
+++ /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/payment-request/show-method-optional-promise-rejects.https-actual.txt
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: Unhandled Promise Rejection: SyntaxError: test
 
 FAIL Rejection of detailsPromise must abort the update with an 'AbortError' DOMException. promise_rejects_dom: badDetails must cause acceptPromise to reject with expectedError function "function () { throw e }" threw object "SecurityError: show() must be triggered by user activation." that is not a DOMException AbortError: property "code" is equal to 18, expected 20
 FAIL Total in the update is a string, so converting to IDL must abort the update with a TypeError. promise_rejects_js: badDetails must cause acceptPromise to reject with expectedError function "function () { throw e }" threw object "SecurityError: show() must be triggered by user activation." ("SecurityError") expected instance of function "function TypeError() {

[Chris Dumez]

(In reply to Truitt Savell from comment #8)
> imported/w3c/web-platform-tests/payment-request/show-method-optional-promise-
> rejects.https.html
> 
> is a flaky failure after its move.
> 
> 
> 
>  Diff:
> ---
> /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/
> imported/w3c/web-platform-tests/payment-request/show-method-optional-promise-
> rejects.https-expected.txt
> +++
> /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/
> imported/w3c/web-platform-tests/payment-request/show-method-optional-promise-
> rejects.https-actual.txt
> @@ -1,3 +1,4 @@
> +CONSOLE MESSAGE: Unhandled Promise Rejection: SyntaxError: test
>  
>  FAIL Rejection of detailsPromise must abort the update with an 'AbortError'
> DOMException. promise_rejects_dom: badDetails must cause acceptPromise to
> reject with expectedError function "function () { throw e }" threw object
> "SecurityError: show() must be triggered by user activation." that is not a
> DOMException AbortError: property "code" is equal to 18, expected 20
>  FAIL Total in the update is a string, so converting to IDL must abort the
> update with a TypeError. promise_rejects_js: badDetails must cause
> acceptPromise to reject with expectedError function "function () { throw e
> }" threw object "SecurityError: show() must be triggered by user
> activation." ("SecurityError") expected instance of function "function
> TypeError() {

Fixed in <https://trac.webkit.org/changeset/269276>, thanks.