Bug 218308 - Resync web-platform-tests/payment-request tests from upstream
Summary: Resync web-platform-tests/payment-request tests from upstream
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-28 15:13 PDT by Chris Dumez
Modified: 2020-11-02 14:36 PST (History)
16 users (show)

See Also:


Attachments
Patch (258.20 KB, patch)
2020-10-28 15:21 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (268.32 KB, patch)
2020-10-29 08:36 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (269.75 KB, patch)
2020-10-29 13:21 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-10-28 15:13:00 PDT
Resync web-platform-tests/payment-request tests from upstream.
Comment 1 Chris Dumez 2020-10-28 15:21:23 PDT
Created attachment 412576 [details]
Patch
Comment 2 Chris Dumez 2020-10-29 08:36:42 PDT
Created attachment 412652 [details]
Patch
Comment 3 Geoffrey Garen 2020-10-29 09:33:37 PDT
Comment on attachment 412652 [details]
Patch

rs=me
Comment 4 Chris Dumez 2020-10-29 13:21:15 PDT
Created attachment 412677 [details]
Patch
Comment 5 Chris Dumez 2020-10-29 13:24:02 PDT
Comment on attachment 412677 [details]
Patch

Clearing flags on attachment: 412677

Committed r269164: <https://trac.webkit.org/changeset/269164>
Comment 6 Chris Dumez 2020-10-29 13:24:05 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2020-10-29 13:25:21 PDT
<rdar://problem/70822990>
Comment 8 Truitt Savell 2020-11-02 14:31:18 PST
imported/w3c/web-platform-tests/payment-request/show-method-optional-promise-rejects.https.html

is a flaky failure after its move.



 Diff:
--- /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/payment-request/show-method-optional-promise-rejects.https-expected.txt
+++ /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/payment-request/show-method-optional-promise-rejects.https-actual.txt
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: Unhandled Promise Rejection: SyntaxError: test
 
 FAIL Rejection of detailsPromise must abort the update with an 'AbortError' DOMException. promise_rejects_dom: badDetails must cause acceptPromise to reject with expectedError function "function () { throw e }" threw object "SecurityError: show() must be triggered by user activation." that is not a DOMException AbortError: property "code" is equal to 18, expected 20
 FAIL Total in the update is a string, so converting to IDL must abort the update with a TypeError. promise_rejects_js: badDetails must cause acceptPromise to reject with expectedError function "function () { throw e }" threw object "SecurityError: show() must be triggered by user activation." ("SecurityError") expected instance of function "function TypeError() {
Comment 9 Chris Dumez 2020-11-02 14:36:00 PST
(In reply to Truitt Savell from comment #8)
> imported/w3c/web-platform-tests/payment-request/show-method-optional-promise-
> rejects.https.html
> 
> is a flaky failure after its move.
> 
> 
> 
>  Diff:
> ---
> /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/
> imported/w3c/web-platform-tests/payment-request/show-method-optional-promise-
> rejects.https-expected.txt
> +++
> /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/
> imported/w3c/web-platform-tests/payment-request/show-method-optional-promise-
> rejects.https-actual.txt
> @@ -1,3 +1,4 @@
> +CONSOLE MESSAGE: Unhandled Promise Rejection: SyntaxError: test
>  
>  FAIL Rejection of detailsPromise must abort the update with an 'AbortError'
> DOMException. promise_rejects_dom: badDetails must cause acceptPromise to
> reject with expectedError function "function () { throw e }" threw object
> "SecurityError: show() must be triggered by user activation." that is not a
> DOMException AbortError: property "code" is equal to 18, expected 20
>  FAIL Total in the update is a string, so converting to IDL must abort the
> update with a TypeError. promise_rejects_js: badDetails must cause
> acceptPromise to reject with expectedError function "function () { throw e
> }" threw object "SecurityError: show() must be triggered by user
> activation." ("SecurityError") expected instance of function "function
> TypeError() {

Fixed in <https://trac.webkit.org/changeset/269276>, thanks.