Bug 218306 - Make run-webkit-test support filter attached devices by udid
Summary: Make run-webkit-test support filter attached devices by udid
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zhifei Fang
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-28 13:42 PDT by Zhifei Fang
Modified: 2020-11-05 16:30 PST (History)
6 users (show)

See Also:


Attachments
Patch (3.72 KB, patch)
2020-10-28 13:46 PDT, Zhifei Fang
no flags Details | Formatted Diff | Diff
Patch (4.40 KB, patch)
2020-11-05 13:35 PST, Zhifei Fang
no flags Details | Formatted Diff | Diff
Patch (4.43 KB, patch)
2020-11-05 14:24 PST, Zhifei Fang
zhifei_fang: review?
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zhifei Fang 2020-10-28 13:42:37 PDT
Make run-webkit-test support filter attached devices by udid
Comment 1 Zhifei Fang 2020-10-28 13:46:39 PDT
Created attachment 412570 [details]
Patch
Comment 2 Zhifei Fang 2020-10-28 13:48:16 PDT
<rdar://34412623>
Comment 3 Zhifei Fang 2020-10-28 13:56:14 PDT
This is also need an internal part
Comment 4 Aakash Jain 2020-10-28 15:50:09 PDT
Please check if it breaks layout tests on ios: https://ews-build.webkit.org/#/builders/51/builds/672

File "Tools/Scripts/webkitpy/port/device_port.py", line 47, in __init__
    self.udids = options.udid.split(',') if options and options.udid else None
AttributeError: Values instance has no attribute 'udid'
Comment 5 Radar WebKit Bug Importer 2020-11-04 12:43:17 PST
<rdar://problem/71047801>
Comment 6 Zhifei Fang 2020-11-05 13:35:26 PST
Created attachment 413350 [details]
Patch
Comment 7 Zhifei Fang 2020-11-05 14:24:46 PST
Created attachment 413352 [details]
Patch
Comment 8 Jonathan Bedard 2020-11-05 16:30:54 PST
Comment on attachment 413352 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413352&action=review

> Tools/Scripts/webkitpy/xcode/simulated_device.py:162
> +    def available_devices(host=None, udids=None):

Wanted to check before this landed, and it turns out that simulated devices do indeed have udidis, if we're passing this in, seems that we should use it.