Bug 218301 - Web Inspector: Sources: creating a local override when viewing a resource should automatically place the cursor where it was before
Summary: Web Inspector: Sources: creating a local override when viewing a resource sho...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks: 242524
  Show dependency treegraph
 
Reported: 2020-10-28 11:39 PDT by Devin Rousso
Modified: 2022-07-08 10:35 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2020-10-28 11:39:20 PDT
I often create local overrides once I notice that there's something I want to change in a resource.  This often happens far down in the resource, so it's annoying to have to re-find the code that I wanted to change after creating the local override.  It'd be ideal to copy/propagate my current selection/scroll to the new content view shown for the local override so that after hitting the button I can instantly start editing.

# STEPS TO REPRODUCE
1. inspect any page
2. select a text-based resource (i.e. not an image) in the Sources Tab
3. scroll down and place the cursor somewhere near the end of the resource
4. click the Create Local Override navigation item

# EXPECTED
a new local override is created for the selected resource with my cursor/selection being exactly where it was before

# ACTUAL
a new local override is created and the newly shown content view is scrolled to the top
Comment 1 Radar WebKit Bug Importer 2020-10-28 11:39:38 PDT
<rdar://problem/70773143>
Comment 2 Devin Rousso 2022-05-27 16:21:01 PDT
Pull request: https://github.com/WebKit/WebKit/pull/1129
Comment 3 EWS 2022-06-03 13:30:22 PDT
Committed r295224 (251279@main): <https://commits.webkit.org/251279@main>

Reviewed commits have been landed. Closing PR #1129 and removing active labels.