Bug 218294 – [MSE] Handle trackId changing across Initialization Segments

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

[MSE] Handle trackId changing across Initialization Segments

[Radar WebKit Bug Importer]

<rdar://problem/70771306>

[Jer Noble]

Created attachment 412546 [details]
Patch

[Peng Liu]

Comment on attachment 412546 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412546&action=review

> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:1166
> +                }

Nit. There seems to be some duplicated code snippets, can we define a function for them?

> LayoutTests/media/media-source/media-source-trackid-change.html:66
> +            consoleWrite('Modify an Media Segment to have a different trackID');

Nit. s/an Media/a Media/

[Jer Noble]

(In reply to Peng Liu from comment #3)
> Comment on attachment 412546 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=412546&action=review
> 
> > Source/WebCore/Modules/mediasource/SourceBuffer.cpp:1166
> > +                }
> 
> Nit. There seems to be some duplicated code snippets, can we define a
> function for them?

Not really as they're all different types.

> > LayoutTests/media/media-source/media-source-trackid-change.html:66
> > +            consoleWrite('Modify an Media Segment to have a different trackID');
> 
> Nit. s/an Media/a Media/

Will change.

[Eric Carlson]

Comment on attachment 412546 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412546&action=review

> Source/WebCore/ChangeLog:5
> +

Nit: <rdar://problem/????>

[Jer Noble]

Created attachment 412563 [details]
Patch for landing

[EWS]

Committed r269121: <https://trac.webkit.org/changeset/269121>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412563 [details].