RESOLVED FIXED 218294
[MSE] Handle trackId changing across Initialization Segments
https://bugs.webkit.org/show_bug.cgi?id=218294
Summary [MSE] Handle trackId changing across Initialization Segments
Jer Noble
Reported 2020-10-28 10:48:46 PDT
[MSE] Handle trackId changing across Initialization Segments
Attachments
Patch (13.57 KB, patch)
2020-10-28 11:02 PDT, Jer Noble
no flags
Patch for landing (13.63 KB, patch)
2020-10-28 12:54 PDT, Jer Noble
no flags
Radar WebKit Bug Importer
Comment 1 2020-10-28 11:02:41 PDT
Jer Noble
Comment 2 2020-10-28 11:02:53 PDT
Peng Liu
Comment 3 2020-10-28 11:25:23 PDT
Comment on attachment 412546 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412546&action=review > Source/WebCore/Modules/mediasource/SourceBuffer.cpp:1166 > + } Nit. There seems to be some duplicated code snippets, can we define a function for them? > LayoutTests/media/media-source/media-source-trackid-change.html:66 > + consoleWrite('Modify an Media Segment to have a different trackID'); Nit. s/an Media/a Media/
Jer Noble
Comment 4 2020-10-28 11:43:26 PDT
(In reply to Peng Liu from comment #3) > Comment on attachment 412546 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=412546&action=review > > > Source/WebCore/Modules/mediasource/SourceBuffer.cpp:1166 > > + } > > Nit. There seems to be some duplicated code snippets, can we define a > function for them? Not really as they're all different types. > > LayoutTests/media/media-source/media-source-trackid-change.html:66 > > + consoleWrite('Modify an Media Segment to have a different trackID'); > > Nit. s/an Media/a Media/ Will change.
Eric Carlson
Comment 5 2020-10-28 12:46:28 PDT
Comment on attachment 412546 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412546&action=review > Source/WebCore/ChangeLog:5 > + Nit: <rdar://problem/????>
Jer Noble
Comment 6 2020-10-28 12:54:33 PDT
Created attachment 412563 [details] Patch for landing
EWS
Comment 7 2020-10-28 13:43:12 PDT
Committed r269121: <https://trac.webkit.org/changeset/269121> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412563 [details].
Note You need to log in before you can comment on or make changes to this bug.