Bug 218291 - [Testing] Remove requirement of adding new SPI for each preference that needs testing (WebKitLegacy Windows)
Summary: [Testing] Remove requirement of adding new SPI for each preference that needs...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-28 09:57 PDT by Sam Weinig
Modified: 2020-12-24 17:59 PST (History)
3 users (show)

See Also:

Attachments
Patch (4.53 KB, patch)
2020-10-28 09:57 PDT, Sam Weinig 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (4.54 KB, patch)
2020-10-28 10:10 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (4.57 KB, patch)
2020-10-28 11:25 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (13.30 KB, patch)
2020-10-28 12:27 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (13.64 KB, patch)
2020-10-28 15:54 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (13.92 KB, patch)
2020-10-28 19:02 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-10-28 09:57:15 PDT 
[Testing] Remove requirement of adding new SPI for each preference that needs testing (WebKitLegacy Windows)
Comment 1 Sam Weinig 2020-10-28 09:57:32 PDT Comment hidden (obsolete)
Comment 2 Sam Weinig 2020-10-28 10:10:17 PDT Comment hidden (obsolete)
Comment 3 Sam Weinig 2020-10-28 11:25:08 PDT Comment hidden (obsolete)
Comment 4 Sam Weinig 2020-10-28 12:27:10 PDT 
Created attachment 412559 [details]
Patch
Comment 5 Sam Weinig 2020-10-28 13:53:03 PDT 
Brent, any idea why the Apple Windows bot has this error:

error C2039: 'setBoolPreferenceForTesting': is not a member of 'IWebPreferencesPrivate8.

Is there something else I need to do to add functions to IWebPreferencesPrivate8 other than what I am doing?
Comment 6 Brent Fulgham 2020-10-28 15:33:03 PDT 
I don't see any problems with your code. I suspect we need to force a clean build because of some dependency issue in the Windows build.
Comment 7 Brent Fulgham 2020-10-28 15:42:51 PDT 
Comment on attachment 412559 [details]
Patch

r=me. The Windows build failure is not because of this change, but is a symptom of a dependency problem in the IDL generation on Windows. We may need to force a clean build once this lands.
Comment 8 Sam Weinig 2020-10-28 15:54:54 PDT 
Created attachment 412580 [details]
Patch
Comment 9 Sam Weinig 2020-10-28 19:02:48 PDT 
Created attachment 412600 [details]
Patch
Comment 10 EWS 2020-10-29 11:18:15 PDT 
Committed r269157: <https://trac.webkit.org/changeset/269157>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412600 [details].
Comment 11 Radar WebKit Bug Importer 2020-10-29 11:19:21 PDT 
<rdar://problem/70817654>
Comment 12 Fujii Hironori 2020-12-24 17:59:49 PST 
Filed: Bug 220145 – [WinCairo][DumpRenderTree] Some JS tests are timing out only in Debug builds since r269157