Bug 218270 - [GTK4] Build broken with GTK 3.99.3
Summary: [GTK4] Build broken with GTK 3.99.3
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords:
: 218226 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-10-27 18:29 PDT by Adrian Perez
Modified: 2020-10-28 02:31 PDT (History)
8 users (show)

See Also:

Attachments
Patch (6.38 KB, patch)
2020-10-27 18:36 PDT, Adrian Perez 		no flags Details | Formatted Diff | Diff
Patch for landing (6.42 KB, patch)
2020-10-28 01:52 PDT, Adrian Perez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2020-10-27 18:29:29 PDT 
SSIA
Comment 1 Adrian Perez 2020-10-27 18:36:53 PDT 
Created attachment 412495 [details]
Patch
Comment 2 EWS Watchlist 2020-10-27 18:37:35 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Alice Mikhaylenko 2020-10-28 00:16:01 PDT 
*** Bug 218226 has been marked as a duplicate of this bug. ***
Comment 4 Carlos Garcia Campos 2020-10-28 01:06:16 PDT 
Comment on attachment 412495 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412495&action=review

> Source/WebKit/UIProcess/Gamepad/gtk/UIGamepadProviderGtk.cpp:50
> +    for (auto *child = gtk_widget_get_first_child(widget); child; child = gtk_widget_get_next_sibling(child)) {

auto* child
Comment 5 Adrian Perez 2020-10-28 01:52:26 PDT 
Created attachment 412512 [details]
Patch for landing
Comment 6 EWS 2020-10-28 02:31:21 PDT 
Committed r269096: <https://trac.webkit.org/changeset/269096>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412512 [details].