Bug 218265 – AudioBuffer.getChannelData(x) should keep returning the same JS wrapper for a given channel

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Audio

[Chris Dumez]

AudioBuffer.getChannelData(x) should keep returning the same JS wrapper for a given channel. This is the behavior of Blink / Gecko and is covered by Web-Platform-Tests.

[Chris Dumez]

Created attachment 412469 [details]
Patch

[Chris Dumez]

Comment on attachment 412469 [details]
Patch

Build errors.

[Chris Dumez]

Created attachment 412470 [details]
Patch

[Chris Dumez]

Created attachment 412473 [details]
Patch

[Geoffrey Garen]

Comment on attachment 412473 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412473&action=review

r=me

> Source/WebCore/Modules/webaudio/AudioBuffer.cpp:156
> +void AudioBuffer::visitChannelsWrappers(JSC::SlotVisitor& visitor)

Also visitChannelWrappers

> Source/WebCore/Modules/webaudio/AudioBuffer.h:82
> +    Vector<JSValueInWrappedObject> m_channelsWrappers;

I would call this m_channelWrappers. Each wrapper wraps one channel.

[Chris Dumez]

Created attachment 412475 [details]
Patch

[EWS]

Geoff Garren found in /Volumes/Data/worker/Commit-Queue/build/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/worker/Commit-Queue/build/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

[Chris Dumez]

Created attachment 412476 [details]
Patch

[EWS]

Committed r269081: <https://trac.webkit.org/changeset/269081>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412476 [details].

[Radar WebKit Bug Importer]

<rdar://problem/70745174>