Bug 218265 - AudioBuffer.getChannelData(x) should keep returning the same JS wrapper for a given channel
Summary: AudioBuffer.getChannelData(x) should keep returning the same JS wrapper for a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 212611 218286
  Show dependency tree / graph
 
Reported: 2020-10-27 15:42 PDT by Chris Dumez
Modified: 2020-10-28 09:04 PDT (History)
14 users (show)

See Also:

Attachments
Patch (11.56 KB, patch)
2020-10-27 15:44 PDT, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (13.51 KB, patch)
2020-10-27 15:47 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (13.44 KB, patch)
2020-10-27 15:59 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (13.42 KB, patch)
2020-10-27 16:24 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (13.42 KB, patch)
2020-10-27 16:27 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-10-27 15:42:23 PDT 
AudioBuffer.getChannelData(x) should keep returning the same JS wrapper for a given channel. This is the behavior of Blink / Gecko and is covered by Web-Platform-Tests.
Comment 1 Chris Dumez 2020-10-27 15:44:40 PDT 
Created attachment 412469 [details]
Patch
Comment 2 Chris Dumez 2020-10-27 15:46:00 PDT 
Comment on attachment 412469 [details]
Patch

Build errors.
Comment 3 Chris Dumez 2020-10-27 15:47:13 PDT 
Created attachment 412470 [details]
Patch
Comment 4 Chris Dumez 2020-10-27 15:59:27 PDT 
Created attachment 412473 [details]
Patch
Comment 5 Geoffrey Garen 2020-10-27 16:13:20 PDT 
Comment on attachment 412473 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412473&action=review

r=me

> Source/WebCore/Modules/webaudio/AudioBuffer.cpp:156
> +void AudioBuffer::visitChannelsWrappers(JSC::SlotVisitor& visitor)

Also visitChannelWrappers

> Source/WebCore/Modules/webaudio/AudioBuffer.h:82
> +    Vector<JSValueInWrappedObject> m_channelsWrappers;

I would call this m_channelWrappers. Each wrapper wraps one channel.
Comment 6 Chris Dumez 2020-10-27 16:24:40 PDT 
Created attachment 412475 [details]
Patch
Comment 7 EWS 2020-10-27 16:25:47 PDT 
Geoff Garren found in /Volumes/Data/worker/Commit-Queue/build/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/worker/Commit-Queue/build/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Comment 8 Chris Dumez 2020-10-27 16:27:19 PDT 
Created attachment 412476 [details]
Patch
Comment 9 EWS 2020-10-27 17:06:08 PDT 
Committed r269081: <https://trac.webkit.org/changeset/269081>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412476 [details].
Comment 10 Radar WebKit Bug Importer 2020-10-27 17:09:51 PDT 
<rdar://problem/70745174>