Bug 218264 - Make RenderingMode a bool enum and remove ShouldAccelerate
Summary: Make RenderingMode a bool enum and remove ShouldAccelerate
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks: 217735
  Show dependency treegraph
 
Reported: 2020-10-27 15:41 PDT by Said Abou-Hallawa
Modified: 2020-10-27 18:37 PDT (History)
15 users (show)

See Also:


Attachments
Patch (28.68 KB, patch)
2020-10-27 16:09 PDT, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff
Patch (28.73 KB, patch)
2020-10-27 17:12 PDT, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2020-10-27 15:41:38 PDT
The following four values are only used in one instance of ImageBuffer::create():

RenderingMode::DisplayListAccelerated,
RenderingMode::DisplayListUnaccelerated,
RenderingMode::RemoteAccelerated,
RenderingMode::RemoteUnaccelerated

Many places in the code convert from RenderingMode to ShouldAccelerate and vice versa. Also one of the WebChromeClient::createImageBuffer() always returns null since it does not override its virtual function in the base class ChromeClient.

So RenderingMode is converted back to be a bool enum as it was before and ShouldAccelerate will be removed. No conversion is needed anymore. And only one instance of ImageBuffer::create() will be handling  creating the remote and display list ImageBuffers.
Comment 1 Said Abou-Hallawa 2020-10-27 16:09:43 PDT
Created attachment 412474 [details]
Patch
Comment 2 Said Abou-Hallawa 2020-10-27 17:12:00 PDT
Created attachment 412479 [details]
Patch
Comment 3 EWS 2020-10-27 18:36:55 PDT
Committed r269084: <https://trac.webkit.org/changeset/269084>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412479 [details].
Comment 4 Radar WebKit Bug Importer 2020-10-27 18:37:28 PDT
<rdar://problem/70747549>