RESOLVED FIXED218263
Remove leftover DiagnosticLoggingKey after r268458 
https://bugs.webkit.org/show_bug.cgi?id=218263
Summary Remove leftover DiagnosticLoggingKey after r268458
Brent Fulgham
Reported 2020-10-27 14:25:04 PDT
When we removed the old ITP telemetry in Bug 217665, we didn't remove the DiagnosticLoggingKey for this content. To avoid future confusion, let's remove it.
Attachments
Patch (2.50 KB, patch)
2020-10-27 14:28 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.49 KB, patch)
2020-10-27 14:36 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2020-10-27 14:26:05 PDT
<rdar://problem/70738034>
Brent Fulgham
Comment 2 2020-10-27 14:28:40 PDT
Created attachment 412465 [details] Patch
Darin Adler
Comment 3 2020-10-27 14:31:34 PDT
Comment on attachment 412465 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412465&action=review > Source/WebCore/ChangeLog:3 > + REGRESSION(r268458): Remove leftover DiagnosticLoggingKey Seems really strange to call this REGRESSION. An unused function has no effect other than making the binary a little bigger.
Brent Fulgham
Comment 4 2020-10-27 14:34:26 PDT
(In reply to Darin Adler from comment #3) > Comment on attachment 412465 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=412465&action=review > > > Source/WebCore/ChangeLog:3 > > + REGRESSION(r268458): Remove leftover DiagnosticLoggingKey > > Seems really strange to call this REGRESSION. > > An unused function has no effect other than making the binary a little > bigger. Fair point -- I'll just reference the change where we forgot to remove this.
Brent Fulgham
Comment 5 2020-10-27 14:36:34 PDT
Created attachment 412466 [details] Patch for landing
EWS
Comment 6 2020-10-27 15:22:05 PDT
Committed r269078: <https://trac.webkit.org/changeset/269078> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412466 [details].
Note You need to log in before you can comment on or make changes to this bug.