Bug 218262 - Web Inspector: truncate data URLs in the Resources sidebar and Headers panel
Summary: Web Inspector: truncate data URLs in the Resources sidebar and Headers panel
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-27 14:07 PDT by Devin Rousso
Modified: 2020-11-18 15:43 PST (History)
5 users (show)

See Also:


Attachments
Patch (3.64 KB, patch)
2020-10-27 14:15 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
[Image] after Patch is applied (155.68 KB, image/png)
2020-10-27 14:23 PDT, Devin Rousso
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2020-10-27 14:07:29 PDT
.
Comment 1 Devin Rousso 2020-10-27 14:15:36 PDT
Created attachment 412463 [details]
Patch
Comment 2 Joseph Pecoraro 2020-10-27 14:18:01 PDT
Screenshot? I normally copy/paste from there, does copy still work?
Comment 3 Darin Adler 2020-10-27 14:18:25 PDT
Oops, didn’t see Joe’s comment.
Comment 4 Devin Rousso 2020-10-27 14:23:21 PDT
Created attachment 412464 [details]
[Image] after Patch is applied

(In reply to Joseph Pecoraro from comment #2)
> Screenshot? I normally copy/paste from there, does copy still work?
You can still right-click the resource in the navigation sidebar and Copy Link.

For large data URLs (i.e. >10k), it doesn't make a lot of sense to try to copy it from the sidebar IMO.  Not to mention, for large data URLs they likely scroll off the screen.
Comment 5 Devin Rousso 2020-10-27 14:25:21 PDT
(In reply to Devin Rousso from comment #4)
> For large data URLs (i.e. >10k), it doesn't make a lot of sense to try to copy it from the sidebar IMO.
err, sorry that wasn't entirely clear.  By "sidebar" I meant "in the Initiated section of the Resource panel in the details sidebar"
Comment 6 Joseph Pecoraro 2020-10-27 14:41:41 PDT
(In reply to Devin Rousso from comment #5)
> (In reply to Devin Rousso from comment #4)
> > For large data URLs (i.e. >10k), it doesn't make a lot of sense to try to copy it from the sidebar IMO.
> err, sorry that wasn't entirely clear.  By "sidebar" I meant "in the
> Initiated section of the Resource panel in the details sidebar"

Sounds good.

I'd still expect the full URL to show up in the "Location" section of the Resource Details sidebar. But I agree in the Initiated Section truncation is better (as long as the link takes you to the resource appropriately!).
Comment 7 EWS 2020-10-27 14:49:43 PDT
Committed r269075: <https://trac.webkit.org/changeset/269075>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412463 [details].
Comment 8 Radar WebKit Bug Importer 2020-10-27 14:50:22 PDT
<rdar://problem/70739410>