See https://bugs.webkit.org/show_bug.cgi?id=218245
Created attachment 412734 [details] Patch
Comment on attachment 412734 [details] Patch lgtm
Comment on attachment 412734 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412734&action=review > Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.cpp:229 > +int ImageDecoderGStreamer::InnerDecoder::decodebinSelectStreamCallback(GstElement*, GstStreamCollection*, GstStream* stream, ImageDecoderGStreamer::InnerDecoder* decoder) > +{ > + return decoder->selectStream(stream); > +} I would use a lambda instead of this. > Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.cpp:244 > + int result = (gst_stream_get_stream_type(stream) & GST_STREAM_TYPE_VIDEO) ? 1 : 0; You don't need the () around gst_stream_get_stream_type(stream) & GST_STREAM_TYPE_VIDEO
Committed r269839: <https://trac.webkit.org/changeset/269839>
<rdar://problem/71431266>