Bug 218246 - [GStreamer] Switch the ImageDecoder to decodebin3
Summary: [GStreamer] Switch the ImageDecoder to decodebin3
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-27 10:43 PDT by Philippe Normand
Modified: 2020-11-16 01:29 PST (History)
8 users (show)

See Also:


Attachments
Patch (5.83 KB, patch)
2020-10-30 06:04 PDT, Philippe Normand
calvaris: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2020-10-27 10:43:03 PDT
See https://bugs.webkit.org/show_bug.cgi?id=218245
Comment 1 Philippe Normand 2020-10-30 06:04:13 PDT
Created attachment 412734 [details]
Patch
Comment 2 Thibault Saunier 2020-10-30 06:19:08 PDT
Comment on attachment 412734 [details]
Patch

lgtm
Comment 3 Xabier Rodríguez Calvar 2020-11-02 05:07:04 PST
Comment on attachment 412734 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412734&action=review

> Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.cpp:229
> +int ImageDecoderGStreamer::InnerDecoder::decodebinSelectStreamCallback(GstElement*, GstStreamCollection*, GstStream* stream, ImageDecoderGStreamer::InnerDecoder* decoder)
> +{
> +    return decoder->selectStream(stream);
> +}

I would use a lambda instead of this.

> Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.cpp:244
> +    int result = (gst_stream_get_stream_type(stream) & GST_STREAM_TYPE_VIDEO) ? 1 : 0;

You don't need the () around gst_stream_get_stream_type(stream) & GST_STREAM_TYPE_VIDEO
Comment 4 Philippe Normand 2020-11-16 01:28:22 PST
Committed r269839: <https://trac.webkit.org/changeset/269839>
Comment 5 Radar WebKit Bug Importer 2020-11-16 01:29:17 PST
<rdar://problem/71431266>