Bug 218231 - [WPE] REGRESSION(r268992) Redefinition of min() inside TextureMapperShaderProgram for GLES > 3.0
Summary: [WPE] REGRESSION(r268992) Redefinition of min() inside TextureMapperShaderPro...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Miguel Gomez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-27 07:35 PDT by Miguel Gomez
Modified: 2020-10-27 08:34 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.94 KB, patch)
2020-10-27 07:43 PDT, Miguel Gomez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Miguel Gomez 2020-10-27 07:35:01 PDT 
r268992 added a definition of the function min() inside the shader, as that function is not defined in GLES2. But when using GLES we don't check for the version, so the new function is defined for every version, causing an error when GLES is bigger than 3.0 and the function is already defined.

I'll go for the simpler path and remove the usage of the min function, so we don't need to add version checks when using GLES.
Comment 1 Miguel Gomez 2020-10-27 07:43:36 PDT 
Created attachment 412419 [details]
Patch
Comment 2 EWS 2020-10-27 08:34:06 PDT 
Committed r269040: <https://trac.webkit.org/changeset/269040>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412419 [details].