WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
218231
[WPE] REGRESSION(
r268992
) Redefinition of min() inside TextureMapperShaderProgram for GLES > 3.0
https://bugs.webkit.org/show_bug.cgi?id=218231
Summary
[WPE] REGRESSION(r268992) Redefinition of min() inside TextureMapperShaderPro...
Miguel Gomez
Reported
2020-10-27 07:35:01 PDT
r268992
added a definition of the function min() inside the shader, as that function is not defined in GLES2. But when using GLES we don't check for the version, so the new function is defined for every version, causing an error when GLES is bigger than 3.0 and the function is already defined. I'll go for the simpler path and remove the usage of the min function, so we don't need to add version checks when using GLES.
Attachments
Patch
(2.94 KB, patch)
2020-10-27 07:43 PDT
,
Miguel Gomez
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Miguel Gomez
Comment 1
2020-10-27 07:43:36 PDT
Created
attachment 412419
[details]
Patch
EWS
Comment 2
2020-10-27 08:34:06 PDT
Committed
r269040
: <
https://trac.webkit.org/changeset/269040
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 412419
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug