Bug 218227 – [ews] Ensure that uat instance doesn't send emails

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

uat instance (ews-buidl.webkit-uat.org) is for testing purposes and various times it runs queues/configurations which aren't ready for production yet. We should ensure that uat instance doesn't send emails to users.

[Aakash Jain]

Created attachment 412414 [details]
Patch

[Darin Adler]

Comment on attachment 412414 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412414&action=review

> Tools/BuildSlaveSupport/ews-build/send_email.py:52
> +    if 'uat' in HOSTNAME:

This seems like an imprecise check. Is there no chance that a host might have "uat" as a substring of its name? It’s in words like "graduate".

[Keith Rollin]

Heh. The word that came to my mind was "squat".

The domain in question was "https://ews-build.webkit-uat.org". Would it cause problems to look for "ews-build.webkit-uat.org"? Or "webkit-uat.org"? Or "webkit-uat"? or "-uat.org"?

[Darin Adler]

(In reply to Keith Rollin from comment #3)
> The domain in question was "https://ews-build.webkit-uat.org". Would it
> cause problems to look for "ews-build.webkit-uat.org"? Or "webkit-uat.org"?
> Or "webkit-uat"? or "-uat.org"?

or "-uat." or /\buat\b/

[Aakash Jain]

(In reply to Keith Rollin from comment #3)
> Would it cause problems to look for "ews-build.webkit-uat.org"? Or "webkit-uat.org"? Or "webkit-uat"? or "-uat.org"?
Not really. This particular check is specifically for this host.

In fact any other host matching this check isn't much of a concern, since almost all other hosts will fail the previous check of is_test_mode_enabled. is_test_mode_enabled is disabled only when BUILDBOT_PRODUCTION env variable is set, which is not set by default. We need to set this variable on uat instance since we need it to mimic production environment (e.g.: reading passwords.json file so that we can easily connect bots to it).

Also, no other instance (like local testing instance) should send emails.

Instead of disallowing this particular host, I have reverted the check in updated patch to allow only one host: production EWS instance.

[Aakash Jain]

Created attachment 412525 [details]
Patch

[Aakash Jain]

Created attachment 412529 [details]
Patch

[EWS]

Committed r269106: <https://trac.webkit.org/changeset/269106>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412529 [details].

[Radar WebKit Bug Importer]

<rdar://problem/70766615>