Bug 218223 - Update generate_xcfilelists to accommodate paths with symlinks
Summary: Update generate_xcfilelists to accommodate paths with symlinks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-26 22:33 PDT by Keith Rollin
Modified: 2020-10-27 12:33 PDT (History)
5 users (show)

See Also:


Attachments
Patch (6.02 KB, patch)
2020-10-26 22:36 PDT, Keith Rollin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2020-10-26 22:33:24 PDT
There are cases where file system paths are compared against each other, and where the comparisons are failing because one or the other (or both) make use of symlinks, causing paths that refer to the same location to fail to compare correctly. Address this by resolving path components that are symlinks.
Comment 1 Radar WebKit Bug Importer 2020-10-26 22:33:41 PDT
<rdar://problem/70709808>
Comment 2 Keith Rollin 2020-10-26 22:36:42 PDT
Created attachment 412392 [details]
Patch
Comment 3 Timothy Hatcher 2020-10-27 10:18:50 PDT
This fixed my issue, thanks!
Comment 4 EWS 2020-10-27 12:33:18 PDT
Committed r269063: <https://trac.webkit.org/changeset/269063>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412392 [details].