RESOLVED FIXED 21822
Correct Windows (Cairo) Build 
https://bugs.webkit.org/show_bug.cgi?id=21822
Summary Correct Windows (Cairo) Build
Brent Fulgham
Reported 2008-10-22 19:48:44 PDT
I had mistakenly changed the stub ResourceRequest.h for Curl-based WebKit from my original dummy structure to a void*, believing that this worked just as well. Unfortunately, I had not properly rebuilt, so my original structure-based implementation was still being used in the WebKit.dll build. When I retrieved the updated sources with my 'new' change and rebuild, I found that WebKit.dll would not compile due to conflict between the definition in WebKit.h. The attached patch returns to my original dummy structure, which satisfies the compiler dependencies set by the WebKit.idl interface.
Attachments
Patch to correct Cairo build (Windows) (1.54 KB, patch)
2008-10-22 20:04 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch to correct build issues in WebKit. (1.12 KB, patch)
2008-10-22 21:11 PDT, Brent Fulgham 		oliver: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2008-10-22 20:04:42 PDT
Created attachment 24587 [details] Patch to correct Cairo build (Windows)
Brent Fulgham
Comment 2 2008-10-22 21:11:02 PDT
Created attachment 24589 [details] Patch to correct build issues in WebKit.
Sam Weinig
Comment 3 2008-10-23 13:36:59 PDT
Landed in r37823.
Note You need to log in before you can comment on or make changes to this bug.