Bug 21822 - Correct Windows (Cairo) Build
Summary: Correct Windows (Cairo) Build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-22 19:48 PDT by Brent Fulgham
Modified: 2008-10-23 13:36 PDT (History)
0 users

See Also:

Attachments
Patch to correct Cairo build (Windows) (1.54 KB, patch)
2008-10-22 20:04 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch to correct build issues in WebKit. (1.12 KB, patch)
2008-10-22 21:11 PDT, Brent Fulgham 		oliver: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2008-10-22 19:48:44 PDT 
I had mistakenly changed the stub ResourceRequest.h for Curl-based WebKit from my original dummy structure to a void*, believing that this worked just as well.  Unfortunately, I had not properly rebuilt, so my original structure-based implementation was still being used in the WebKit.dll build.

When I retrieved the updated sources with my 'new' change and rebuild, I found that WebKit.dll would not compile due to conflict between the definition in WebKit.h.

The attached patch returns to my original dummy structure, which satisfies the compiler dependencies set by the WebKit.idl interface.
Comment 1 Brent Fulgham 2008-10-22 20:04:42 PDT 
Created attachment 24587 [details]
Patch to correct Cairo build (Windows)
Comment 2 Brent Fulgham 2008-10-22 21:11:02 PDT 
Created attachment 24589 [details]
Patch to correct build issues in WebKit.
Comment 3 Sam Weinig 2008-10-23 13:36:59 PDT 
Landed in r37823.