Bug 218202 - [LFC] Do not use RenderStyle padding values unless padding is set
Summary: [LFC] Do not use RenderStyle padding values unless padding is set
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-26 13:40 PDT by zalan
Modified: 2020-10-26 15:53 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.91 KB, patch)
2020-10-26 13:45 PDT, zalan
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-10-26 13:40:42 PDT
ssia
Comment 1 zalan 2020-10-26 13:45:31 PDT
Created attachment 412351 [details]
Patch
Comment 2 Antti Koivisto 2020-10-26 14:26:20 PDT
Comment on attachment 412351 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412351&action=review

> Source/WebCore/ChangeLog:9
> +        An unset padding value computes to the passed in maximum value.
> +        (e.g. valueForLength(style.paddingLeft(), 10) -> computed padding left is 10px)

Unset padding should be 0. Which test is this failing?
Comment 3 zalan 2020-10-26 15:52:39 PDT
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 412351 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=412351&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        An unset padding value computes to the passed in maximum value.
> > +        (e.g. valueForLength(style.paddingLeft(), 10) -> computed padding left is 10px)
> 
> Unset padding should be 0. Which test is this failing?
So apparently RenderStyle::resetPadding sets Length(auto) :(
Comment 4 zalan 2020-10-26 15:53:40 PDT
will fix this by resetting the padding properly (to a valid value).