Bug 218175 – [EME][GStreamer] Decode base64 init data if needed

• Status: RESOLVED
• Resolution: INVALID
• Component: New Bugs

[Xabier Rodríguez Calvar]

[EME][GStreamer] Decode base64 init data if needed

[Xabier Rodríguez Calvar]

Created attachment 412304 [details]
Patch

[Philippe Normand]

Comment on attachment 412304 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412304&action=review

> Source/WebCore/platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h:81
> +        GST_CAT_LEVEL_LOG(webkit_media_common_encryption_decrypt_debug_category, GST_LEVEL_TRACE, nullptr, "payload size %zu", m_payload->size());

Seems like this would work only because of unified builds? Can you declare a dedicated log category for this module and make it default? It would reduce macro verbosity and also be useful for the GST_ERROR call in this file.

[Xabier Rodríguez Calvar]

(In reply to Philippe Normand from comment #2)
> Comment on attachment 412304 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=412304&action=review
> 
> > Source/WebCore/platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h:81
> > +        GST_CAT_LEVEL_LOG(webkit_media_common_encryption_decrypt_debug_category, GST_LEVEL_TRACE, nullptr, "payload size %zu", m_payload->size());
> 
> Seems like this would work only because of unified builds? Can you declare a
> dedicated log category for this module and make it default? It would reduce
> macro verbosity and also be useful for the GST_ERROR call in this file.

This is a header file. Declaring a default category seems a bad idea, right?

[Xabier Rodríguez Calvar]

The build problem should be solved by landing patch for bug 218174 first.

[Philippe Normand]

Comment on attachment 412304 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412304&action=review

>>> Source/WebCore/platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h:81
>>> +        GST_CAT_LEVEL_LOG(webkit_media_common_encryption_decrypt_debug_category, GST_LEVEL_TRACE, nullptr, "payload size %zu", m_payload->size());
>> 
>> Seems like this would work only because of unified builds? Can you declare a dedicated log category for this module and make it default? It would reduce macro verbosity and also be useful for the GST_ERROR call in this file.
> 
> This is a header file. Declaring a default category seems a bad idea, right?

Not if you use GST_DEBUG_CATEGORY_EXTERN.

[Xabier Rodríguez Calvar]

Created attachment 412411 [details]
Patch

[EWS]

Committed r269033: <https://trac.webkit.org/changeset/269033>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412411 [details].

[Radar WebKit Bug Importer]

<rdar://problem/70719469>

[Xabier Rodríguez Calvar]

It looks this patch makes media/encrypted-media/clearKey/clearKey-webm-video-playback-mse.html timeout. I'm on it.

[Xabier Rodríguez Calvar]

Reverted r269033 for reason:

269043

Committed r269097: <https://trac.webkit.org/changeset/269097>

[Xabier Rodríguez Calvar]

This solution ain't good, I need to find another one. Reverted and closing.