Bug 218175 - [EME][GStreamer] Decode base64 init data if needed
Summary: [EME][GStreamer] Decode base64 init data if needed
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Xabier Rodríguez Calvar
URL:
Keywords: InRadar
Depends on: 218174
Blocks: 218238
  Show dependency treegraph
 
Reported: 2020-10-26 04:13 PDT by Xabier Rodríguez Calvar
Modified: 2020-10-28 04:48 PDT (History)
7 users (show)

See Also:


Attachments
Patch (2.96 KB, patch)
2020-10-26 04:14 PDT, Xabier Rodríguez Calvar
no flags Details | Formatted Diff | Diff
Patch (2.96 KB, patch)
2020-10-27 05:05 PDT, Xabier Rodríguez Calvar
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xabier Rodríguez Calvar 2020-10-26 04:13:10 PDT
[EME][GStreamer] Decode base64 init data if needed
Comment 1 Xabier Rodríguez Calvar 2020-10-26 04:14:55 PDT
Created attachment 412304 [details]
Patch
Comment 2 Philippe Normand 2020-10-26 04:40:15 PDT
Comment on attachment 412304 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412304&action=review

> Source/WebCore/platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h:81
> +        GST_CAT_LEVEL_LOG(webkit_media_common_encryption_decrypt_debug_category, GST_LEVEL_TRACE, nullptr, "payload size %zu", m_payload->size());

Seems like this would work only because of unified builds? Can you declare a dedicated log category for this module and make it default? It would reduce macro verbosity and also be useful for the GST_ERROR call in this file.
Comment 3 Xabier Rodríguez Calvar 2020-10-26 09:26:15 PDT
(In reply to Philippe Normand from comment #2)
> Comment on attachment 412304 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=412304&action=review
> 
> > Source/WebCore/platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h:81
> > +        GST_CAT_LEVEL_LOG(webkit_media_common_encryption_decrypt_debug_category, GST_LEVEL_TRACE, nullptr, "payload size %zu", m_payload->size());
> 
> Seems like this would work only because of unified builds? Can you declare a
> dedicated log category for this module and make it default? It would reduce
> macro verbosity and also be useful for the GST_ERROR call in this file.

This is a header file. Declaring a default category seems a bad idea, right?
Comment 4 Xabier Rodríguez Calvar 2020-10-26 09:28:15 PDT
The build problem should be solved by landing patch for bug 218174 first.
Comment 5 Philippe Normand 2020-10-26 09:57:38 PDT
Comment on attachment 412304 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412304&action=review

>>> Source/WebCore/platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h:81
>>> +        GST_CAT_LEVEL_LOG(webkit_media_common_encryption_decrypt_debug_category, GST_LEVEL_TRACE, nullptr, "payload size %zu", m_payload->size());
>> 
>> Seems like this would work only because of unified builds? Can you declare a dedicated log category for this module and make it default? It would reduce macro verbosity and also be useful for the GST_ERROR call in this file.
> 
> This is a header file. Declaring a default category seems a bad idea, right?

Not if you use GST_DEBUG_CATEGORY_EXTERN.
Comment 6 Xabier Rodríguez Calvar 2020-10-27 05:05:39 PDT
Created attachment 412411 [details]
Patch
Comment 7 EWS 2020-10-27 06:00:46 PDT
Committed r269033: <https://trac.webkit.org/changeset/269033>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412411 [details].
Comment 8 Radar WebKit Bug Importer 2020-10-27 06:01:22 PDT
<rdar://problem/70719469>
Comment 9 Xabier Rodríguez Calvar 2020-10-27 09:02:10 PDT
It looks this patch makes media/encrypted-media/clearKey/clearKey-webm-video-playback-mse.html timeout. I'm on it.
Comment 10 Xabier Rodríguez Calvar 2020-10-28 04:40:39 PDT
Reverted r269033 for reason:

269043

Committed r269097: <https://trac.webkit.org/changeset/269097>
Comment 11 Xabier Rodríguez Calvar 2020-10-28 04:48:14 PDT
This solution ain't good, I need to find another one. Reverted and closing.