WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
218170
Use a WeakHashSet for Document::m_captionPreferencesChangedElements
https://bugs.webkit.org/show_bug.cgi?id=218170
Summary
Use a WeakHashSet for Document::m_captionPreferencesChangedElements
youenn fablet
Reported
2020-10-26 02:52:00 PDT
Use a WeakHashSet for Document::m_captionPreferencesChangedElements for extra safety
Attachments
Patch
(3.94 KB, patch)
2020-10-26 03:02 PDT
,
youenn fablet
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
Patch
(4.06 KB, patch)
2020-10-26 04:24 PDT
,
youenn fablet
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
Patch
(4.22 KB, patch)
2020-10-26 05:17 PDT
,
youenn fablet
no flags
Details
Formatted Diff
Diff
Patch
(4.22 KB, patch)
2020-10-26 06:10 PDT
,
youenn fablet
no flags
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
youenn fablet
Comment 1
2020-10-26 03:00:52 PDT
<
rdar://problem/64485217
>
youenn fablet
Comment 2
2020-10-26 03:02:30 PDT
Created
attachment 412299
[details]
Patch
youenn fablet
Comment 3
2020-10-26 04:24:49 PDT
Created
attachment 412305
[details]
Patch
youenn fablet
Comment 4
2020-10-26 05:17:25 PDT
Created
attachment 412308
[details]
Patch
youenn fablet
Comment 5
2020-10-26 06:10:46 PDT
Created
attachment 412313
[details]
Patch
youenn fablet
Comment 6
2020-10-26 07:55:22 PDT
Comment on
attachment 412313
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=412313&action=review
> Source/WTF/wtf/WeakHashSet.h:-142 > - for (auto& item : map(m_set, [](auto& item) { return makeWeakPtr(item->template get<T>()); })) {
We need a static_cast here like weak hashset iterator is doing. I changed the code so that wincairo compiles it, which requires removal of some autos.
EWS
Comment 7
2020-10-26 08:35:39 PDT
Committed
r268979
: <
https://trac.webkit.org/changeset/268979
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 412313
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug