RESOLVED FIXED 218159
JSC special function forward declarations (e.g. JSC_DECLARE_HOST_FUNCTION) that are internal to a cpp file should be declared with static to avoid external linkage 
https://bugs.webkit.org/show_bug.cgi?id=218159
Summary JSC special function forward declarations (e.g. JSC_DECLARE_HOST_FUNCTION) th...
Sam Weinig
Reported 2020-10-25 09:43:55 PDT
JSC special function forward declarations (e.g. JSC_DECLARE_HOST_FUNCTION) that are internal to a cpp file should be declared with static to avoid external linkage.
Attachments
Patch (233.57 KB, patch)
2020-10-25 09:49 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (233.50 KB, patch)
2020-10-25 14:00 PDT, Sam Weinig 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (234.08 KB, patch)
2020-10-25 14:27 PDT, Sam Weinig 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (233.93 KB, patch)
2020-10-25 14:34 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (233.69 KB, patch)
2020-10-25 18:23 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2020-10-25 09:49:31 PDT Comment hidden (obsolete)
Sam Weinig
Comment 2 2020-10-25 14:00:45 PDT Comment hidden (obsolete)
Sam Weinig
Comment 3 2020-10-25 14:27:35 PDT Comment hidden (obsolete)
Sam Weinig
Comment 4 2020-10-25 14:34:51 PDT Comment hidden (obsolete)
Sam Weinig
Comment 5 2020-10-25 18:23:29 PDT
Created attachment 412284 [details] Patch
EWS
Comment 6 2020-10-26 11:41:18 PDT
Committed r268990: <https://trac.webkit.org/changeset/268990> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412284 [details].
Radar WebKit Bug Importer
Comment 7 2020-10-26 11:42:37 PDT
<rdar://problem/70688374>
Note You need to log in before you can comment on or make changes to this bug.