Bug 218159 - JSC special function forward declarations (e.g. JSC_DECLARE_HOST_FUNCTION) that are internal to a cpp file should be declared with static to avoid external linkage
Summary: JSC special function forward declarations (e.g. JSC_DECLARE_HOST_FUNCTION) th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-25 09:43 PDT by Sam Weinig
Modified: 2020-10-26 11:42 PDT (History)
15 users (show)

See Also:

Attachments
Patch (233.57 KB, patch)
2020-10-25 09:49 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (233.50 KB, patch)
2020-10-25 14:00 PDT, Sam Weinig 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (234.08 KB, patch)
2020-10-25 14:27 PDT, Sam Weinig 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (233.93 KB, patch)
2020-10-25 14:34 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (233.69 KB, patch)
2020-10-25 18:23 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-10-25 09:43:55 PDT 
JSC special function forward declarations (e.g. JSC_DECLARE_HOST_FUNCTION) that are internal to a cpp file should be declared with static to avoid external linkage.
Comment 1 Sam Weinig 2020-10-25 09:49:31 PDT Comment hidden (obsolete)
Comment 2 Sam Weinig 2020-10-25 14:00:45 PDT Comment hidden (obsolete)
Comment 3 Sam Weinig 2020-10-25 14:27:35 PDT Comment hidden (obsolete)
Comment 4 Sam Weinig 2020-10-25 14:34:51 PDT Comment hidden (obsolete)
Comment 5 Sam Weinig 2020-10-25 18:23:29 PDT 
Created attachment 412284 [details]
Patch
Comment 6 EWS 2020-10-26 11:41:18 PDT 
Committed r268990: <https://trac.webkit.org/changeset/268990>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412284 [details].
Comment 7 Radar WebKit Bug Importer 2020-10-26 11:42:37 PDT 
<rdar://problem/70688374>