Bug 218155 - [LFC Display] Implement background image painting
Summary: [LFC Display] Implement background image painting
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
Keywords: InRadar
Depends on:
Reported: 2020-10-24 15:53 PDT by Simon Fraser (smfr)
Modified: 2020-10-24 21:28 PDT (History)
5 users (show)

See Also:

Patch (52.38 KB, patch)
2020-10-24 15:57 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (52.29 KB, patch)
2020-10-24 19:47 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-10-24 15:53:03 PDT
[LFC Display] Implement background image painting
Comment 1 Simon Fraser (smfr) 2020-10-24 15:57:28 PDT
Created attachment 412251 [details]
Comment 2 Sam Weinig 2020-10-24 17:22:27 PDT
Comment on attachment 412251 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=412251&action=review

> Source/WebCore/display/css/DisplayFillLayerImageGeometry.h:48
> +    FillLayerImageGeometry()

What is this default constructor needed for? Can we remove it?

> Source/WebCore/display/css/DisplayFillLayerImageGeometry.h:53
> +    FillLayerImageGeometry(const FloatRect& destinationRect, const FloatSize& tileSize, const FloatSize& phase, const FloatSize& space, bool fixedAttachment)

Enum rather than a bool for fixedAttachment?
Comment 3 Simon Fraser (smfr) 2020-10-24 19:47:31 PDT
Created attachment 412257 [details]
Comment 4 EWS 2020-10-24 21:27:20 PDT
Committed r268955: <https://trac.webkit.org/changeset/268955>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412257 [details].
Comment 5 Radar WebKit Bug Importer 2020-10-24 21:28:17 PDT