Bug 218149 – [BigSur] Appending a new WebM init segment between Cluster elements throws an error

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

[Cocoa] Appending a new WebM init segment between Cluster elements throws an error

[Jer Noble]

Created attachment 412237 [details]
Patch

[Jer Noble]

<rdar://problem/70416537>

[Eric Carlson]

Comment on attachment 412237 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412237&action=review

r=me once the bots are happy

> Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp:537
> +        INFO_LOG_IF_POSSIBLE(LOGIDENTIFIER, "received Ebml element while parsing Segment element. Rewound reader and reset parser, retrying");

Maybe ALWAYS_LOG_IF_POSSIBLE?

[Jer Noble]

(In reply to Eric Carlson from comment #3)
> Comment on attachment 412237 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=412237&action=review
> 
> r=me once the bots are happy

Yeah I need to skip these new tests on < BigSur

> > Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp:537
> > +        INFO_LOG_IF_POSSIBLE(LOGIDENTIFIER, "received Ebml element while parsing Segment element. Rewound reader and reset parser, retrying");
> 
> Maybe ALWAYS_LOG_IF_POSSIBLE?

Sure.

[Jer Noble]

Created attachment 412242 [details]
Patch for landing

[EWS]

Committed r268952: <https://trac.webkit.org/changeset/268952>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412242 [details].