Bug 218144 – Add null checks and smart pointers in PDF and Plugin code

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

Add null checks and smart pointers in PDF and Plugin code

[Alex Christensen]

Created attachment 412220 [details]
Patch

[Alex Christensen]

Created attachment 412221 [details]
Patch

[youenn fablet]

Comment on attachment 412221 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412221&action=review

> Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:620
> +        Document* document = frame.coreFrame()->document();

auto

> Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:1855
> +    m_frame->page()->updatePDFHUDLocation(*this, frameForHUD());

Are we sure page is non null?

> Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:1922
>      LocalDefaultSystemAppearance localAppearance(page->useDarkAppearance());

Check page?

> Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:2302
> +    if (!m_frame)

Could do if (!m_frame || !m_frame->coreFrame()).

> Source/WebKit/WebProcess/WebPage/WebFrame.h:160
> +    void setLoadListener(LoadListener* loadListener) { m_loadListener = makeWeakPtr(loadListener); }

Could we pass a LoadListener&?

[Alex Christensen]

Comment on attachment 412221 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412221&action=review

>> Source/WebKit/WebProcess/WebPage/WebFrame.h:160
>> +    void setLoadListener(LoadListener* loadListener) { m_loadListener = makeWeakPtr(loadListener); }
> 
> Could we pass a LoadListener&?

nope, but I'll update the old call sites that call it with 0 to call it with nullptr.

[Alex Christensen]

Created attachment 412335 [details]
Patch

[EWS]

Committed r268989: <https://trac.webkit.org/changeset/268989>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412335 [details].

[Radar WebKit Bug Importer]

<rdar://problem/70688355>

[David Kilzer (:ddkilzer)]

<rdar://problem/69931543>