Bug 218134 - [webkitscmpy] Assume default branch when no branch specified
Summary: [webkitscmpy] Assume default branch when no branch specified
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
Keywords: InRadar
Depends on:
Reported: 2020-10-23 13:00 PDT by Jonathan Bedard
Modified: 2020-11-11 16:35 PST (History)
5 users (show)

See Also:

Patch (3.97 KB, patch)
2020-10-23 13:31 PDT, Jonathan Bedard
jbedard: review?
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-10-23 13:00:45 PDT
Currently, if the most recent commit to SVN was not on the default branch, we will attempt to compute identifiers on that branch rather than the default branch. This is also true in Git, but less serious because this can only happen if the user has their checkout on that branch.

I'm not entirely certain what we want the behavior here to be, but I'm fairly certain the current behavior is wrong.
Comment 1 Radar WebKit Bug Importer 2020-10-23 13:01:16 PDT
Comment 2 Jonathan Bedard 2020-10-23 13:01:53 PDT
I think the correct behavior here is to always assume the default branch when no branch is specified, that way the script does not behave differently based on the state of the checkout.
Comment 3 Jonathan Bedard 2020-10-23 13:31:22 PDT
Created attachment 412208 [details]
Comment 4 Jonathan Bedard 2020-11-11 16:35:39 PST
After working on https://bugs.webkit.org/show_bug.cgi?id=218827, I'm quite convinced we should land this change.