Bug 21813 - Enable custom properties for runtime objects in QtWebKit
Summary: Enable custom properties for runtime objects in QtWebKit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-22 15:42 PDT by jade han
Modified: 2008-10-25 08:24 PDT (History)
3 users (show)

See Also:


Attachments
This patch implements the feature (1.93 KB, patch)
2008-10-22 15:44 PDT, jade han
no flags Details | Formatted Diff | Diff
patch that limits behavior to QtInstance, and also expands the autotest for custom properties (2.61 KB, patch)
2008-10-23 06:59 PDT, jade han
no flags Details | Formatted Diff | Diff
similar to previous patch (limits to QtInstance), but removes debug statement (2.59 KB, patch)
2008-10-23 07:01 PDT, jade han
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jade han 2008-10-22 15:42:36 PDT
Enabling custom properties for runtime objects allows us to do myNativeRuntimeObject.foo = "bar", which can be useful.
Comment 1 jade han 2008-10-22 15:44:17 PDT
Created attachment 24576 [details]
This patch implements the feature
Comment 2 Anders Carlsson 2008-10-22 17:48:29 PDT
Comment on attachment 24576 [details]
This patch implements the feature

Are you sure you want to do this for all runtime objects and not just QtInstances? Neither WebKit nor Firefox support setting custom properties on NPObjects for example.
Comment 3 jade han 2008-10-23 06:57:01 PDT
You're right Anders, I will make a new patch that limits this behavior to QtInstance.
Comment 4 jade han 2008-10-23 06:59:27 PDT
Created attachment 24597 [details]
patch that limits  behavior to QtInstance, and also expands the autotest for custom properties
Comment 5 jade han 2008-10-23 07:01:44 PDT
Created attachment 24598 [details]
similar to previous patch (limits to QtInstance), but removes debug statement
Comment 6 Anders Carlsson 2008-10-23 09:04:50 PDT
Comment on attachment 24598 [details]
similar to previous patch (limits to QtInstance), but removes debug statement

Looks great! r=me
Comment 7 Tor Arne Vestbø 2008-10-25 08:24:13 PDT
Thanks for the review Anders!

Landed in r37889