WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
21809
Remove PLATFORM(MAC) wrapper from USE(ATSUI)
https://bugs.webkit.org/show_bug.cgi?id=21809
Summary
Remove PLATFORM(MAC) wrapper from USE(ATSUI)
Mike Pinkerton
Reported
2008-10-22 13:38:55 PDT
The PLATFORM(MAC) wrapping USE(ATSUI) is redundant, since right now it's only defined for Mac. This also makes it impossible moving forward for us to use it in PLATFORM(CHROMIUM) on Mac OS, since we don't define PLATFORM(MAC). Another solution would be to change these lines to PLATFORM(MAC) || PLATFORM(CHROMIUM) but that seems excessive. Just let the platforms that want to use ATSUI define ATSUI and avoid the extraneous ifdef cruft. patch upcoming
Attachments
patch
(1.79 KB, patch)
2008-10-22 13:39 PDT
,
Mike Pinkerton
mitz: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mike Pinkerton
Comment 1
2008-10-22 13:39:59 PDT
Created
attachment 24569
[details]
patch
mitz
Comment 2
2008-10-22 14:46:29 PDT
Comment on
attachment 24569
[details]
patch r=me
Darin Adler
Comment 3
2008-10-22 18:43:58 PDT
http://trac.webkit.org/changeset/37801
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug