Bug 21809 - Remove PLATFORM(MAC) wrapper from USE(ATSUI)
Summary: Remove PLATFORM(MAC) wrapper from USE(ATSUI)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-22 13:38 PDT by Mike Pinkerton
Modified: 2008-10-22 18:43 PDT (History)
0 users

See Also:


Attachments
patch (1.79 KB, patch)
2008-10-22 13:39 PDT, Mike Pinkerton
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Pinkerton 2008-10-22 13:38:55 PDT
The PLATFORM(MAC) wrapping USE(ATSUI) is redundant, since right now it's only defined for Mac. This also makes it impossible moving forward for us to use it in PLATFORM(CHROMIUM) on Mac OS, since we don't define PLATFORM(MAC).

Another solution would be to change these lines to PLATFORM(MAC) || PLATFORM(CHROMIUM) but that seems excessive. Just let the platforms that want to use ATSUI define ATSUI and avoid the extraneous ifdef cruft.

patch upcoming
Comment 1 Mike Pinkerton 2008-10-22 13:39:59 PDT
Created attachment 24569 [details]
patch
Comment 2 mitz 2008-10-22 14:46:29 PDT
Comment on attachment 24569 [details]
patch

r=me
Comment 3 Darin Adler 2008-10-22 18:43:58 PDT
http://trac.webkit.org/changeset/37801