Bug 218088 - [css-logical] Add support for block/inline CSS values for resize property
Summary: [css-logical] Add support for block/inline CSS values for resize property
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
URL:
Keywords: InRadar
Depends on:
Blocks: 185977
  Show dependency treegraph
 
Reported: 2020-10-22 10:24 PDT by Simon Fraser (smfr)
Modified: 2022-04-01 08:37 PDT (History)
15 users (show)

See Also:


Attachments
Patch (13.45 KB, patch)
2022-04-01 03:03 PDT, Tim Nguyen (:ntim)
koivisto: review+
Details | Formatted Diff | Diff
Patch (13.43 KB, patch)
2022-04-01 03:25 PDT, Tim Nguyen (:ntim)
no flags Details | Formatted Diff | Diff
Patch (13.43 KB, patch)
2022-04-01 03:31 PDT, Tim Nguyen (:ntim)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-10-22 10:24:36 PDT
Add logical values for 'resize'
https://drafts.csswg.org/css-ui/#resize
Comment 1 Radar WebKit Bug Importer 2020-10-22 10:25:08 PDT
<rdar://problem/70578888>
Comment 2 Tim Nguyen (:ntim) 2022-04-01 03:03:49 PDT
Created attachment 456342 [details]
Patch
Comment 3 Tim Nguyen (:ntim) 2022-04-01 03:06:29 PDT
Comment on attachment 456342 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456342&action=review

> Source/WebCore/css/CSSProperties.json:-4267
> -            "inherited": true,

Not sure why this was set, but Resize was in StyleRare_Non_InheritedData.h, and per-spec it shouldn't be inherited anyway.
Comment 4 Antti Koivisto 2022-04-01 03:07:52 PDT
Comment on attachment 456342 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456342&action=review

> Source/WebCore/rendering/RenderLayer.cpp:2791
> +    canResizeWidth |= resize == Resize::Horizontal || resize == Resize::Both;

Not a fan of using bitwise operators for boolean logic.
Comment 5 Tim Nguyen (:ntim) 2022-04-01 03:25:45 PDT
Created attachment 456343 [details]
Patch
Comment 6 Tim Nguyen (:ntim) 2022-04-01 03:31:48 PDT
Created attachment 456345 [details]
Patch
Comment 7 EWS 2022-04-01 08:37:05 PDT
Committed r292222 (249125@main): <https://commits.webkit.org/249125@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456345 [details].