RESOLVED FIXED Bug 218088
[css-logical] Add support for block/inline CSS values for resize property 
https://bugs.webkit.org/show_bug.cgi?id=218088
Summary [css-logical] Add support for block/inline CSS values for resize property
Simon Fraser (smfr)
Reported 2020-10-22 10:24:36 PDT
Add logical values for 'resize' https://drafts.csswg.org/css-ui/#resize
Attachments
Patch (13.45 KB, patch)
2022-04-01 03:03 PDT, Tim Nguyen (:ntim) 		koivisto: review+
DetailsFormatted DiffDiff
Patch (13.43 KB, patch)
2022-04-01 03:25 PDT, Tim Nguyen (:ntim) 		no flags
DetailsFormatted DiffDiff
Patch (13.43 KB, patch)
2022-04-01 03:31 PDT, Tim Nguyen (:ntim) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-10-22 10:25:08 PDT
<rdar://problem/70578888>
Tim Nguyen (:ntim)
Comment 2 2022-04-01 03:03:49 PDT
Created attachment 456342 [details] Patch
Tim Nguyen (:ntim)
Comment 3 2022-04-01 03:06:29 PDT
Comment on attachment 456342 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456342&action=review > Source/WebCore/css/CSSProperties.json:-4267 > - "inherited": true, Not sure why this was set, but Resize was in StyleRare_Non_InheritedData.h, and per-spec it shouldn't be inherited anyway.
Antti Koivisto
Comment 4 2022-04-01 03:07:52 PDT
Comment on attachment 456342 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456342&action=review > Source/WebCore/rendering/RenderLayer.cpp:2791 > + canResizeWidth |= resize == Resize::Horizontal || resize == Resize::Both; Not a fan of using bitwise operators for boolean logic.
Tim Nguyen (:ntim)
Comment 5 2022-04-01 03:25:45 PDT
Created attachment 456343 [details] Patch
Tim Nguyen (:ntim)
Comment 6 2022-04-01 03:31:48 PDT
Created attachment 456345 [details] Patch
EWS
Comment 7 2022-04-01 08:37:05 PDT
Committed r292222 (249125@main): <https://commits.webkit.org/249125@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456345 [details].
Note You need to log in before you can comment on or make changes to this bug.