Bug 218084 - Use operand names when dumping Bytecode
Summary: Use operand names when dumping Bytecode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robin Morisset
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-22 09:05 PDT by Robin Morisset
Modified: 2020-10-22 10:46 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.23 KB, patch)
2020-10-22 09:09 PDT, Robin Morisset 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Morisset 2020-10-22 09:05:42 PDT 
It can sometimes be tricky to read dumped bytecode, especially for ops with lots of operands. Thankfully, we have names for each of them. I am just proposing putting them in the dumping format.
Comment 1 Robin Morisset 2020-10-22 09:09:00 PDT 
Created attachment 412103 [details]
Patch
Comment 2 Saam Barati 2020-10-22 10:00:29 PDT 
Comment on attachment 412103 [details]
Patch

nice
Comment 3 EWS 2020-10-22 10:45:58 PDT 
Committed r268871: <https://trac.webkit.org/changeset/268871>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412103 [details].
Comment 4 Radar WebKit Bug Importer 2020-10-22 10:46:24 PDT 
<rdar://problem/70579826>