WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
21808
Update CG ifdefs to include PLATFORM(CHROMIUM)
https://bugs.webkit.org/show_bug.cgi?id=21808
Summary
Update CG ifdefs to include PLATFORM(CHROMIUM)
Mike Pinkerton
Reported
2008-10-22 13:15:12 PDT
PLATFORM(CHROMIUM) on Mac OS uses CG the same way PLATFORM(MAC) does so fix ifdefs to reflect that. WinChromium doesn't define CG so we don't have to further specify the ifdef. Patch upcoming.
Attachments
patch
(1.53 KB, patch)
2008-10-22 13:16 PDT
,
Mike Pinkerton
eric
: review-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mike Pinkerton
Comment 1
2008-10-22 13:16:50 PDT
Created
attachment 24567
[details]
patch patch
Eric Seidel (no email)
Comment 2
2008-10-23 12:42:27 PDT
Comment on
attachment 24567
[details]
patch Your email address is missing. set EMAIL_ADDRESS environment variable I think this should use PLATFORM(DARWIN) instead since this is a platform thing, not a "apple's mac port" thing. If someone is including this header they're already wishing to use CG, so the question is just if we're using CG on a mac or a windows machine. I'll land a fixed version for you.
Eric Seidel (no email)
Comment 3
2008-10-23 13:30:39 PDT
http://trac.webkit.org/changeset/37821
Eric Seidel (no email)
Comment 4
2008-10-23 14:17:46 PDT
r37825
too.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug