Bug 21808 - Update CG ifdefs to include PLATFORM(CHROMIUM)
Summary: Update CG ifdefs to include PLATFORM(CHROMIUM)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-22 13:15 PDT by Mike Pinkerton
Modified: 2008-10-23 14:17 PDT (History)
0 users

See Also:


Attachments
patch (1.53 KB, patch)
2008-10-22 13:16 PDT, Mike Pinkerton
eric: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Pinkerton 2008-10-22 13:15:12 PDT
PLATFORM(CHROMIUM) on Mac OS uses CG the same way PLATFORM(MAC) does so fix ifdefs to reflect that. WinChromium doesn't define CG so we don't have to further specify the ifdef. 

Patch upcoming.
Comment 1 Mike Pinkerton 2008-10-22 13:16:50 PDT
Created attachment 24567 [details]
patch

patch
Comment 2 Eric Seidel (no email) 2008-10-23 12:42:27 PDT
Comment on attachment 24567 [details]
patch

Your email address is missing. 

set EMAIL_ADDRESS environment variable

I think this should use PLATFORM(DARWIN) instead since this is a platform thing, not a "apple's mac port" thing.  If someone is including this header they're already wishing to use CG, so the question is just if we're using CG on a mac or a windows machine.  I'll land a fixed version for you.
Comment 3 Eric Seidel (no email) 2008-10-23 13:30:39 PDT
http://trac.webkit.org/changeset/37821
Comment 4 Eric Seidel (no email) 2008-10-23 14:17:46 PDT
r37825 too.