Bug 218075 - Rename scroll-snap-margin to scroll-margin
Summary: Rename scroll-snap-margin to scroll-margin
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords: InRadar
Depends on:
Blocks: 189265
  Show dependency tree / graph
 
Reported: 2020-10-22 03:43 PDT by Martin Robinson
Modified: 2020-10-22 13:32 PDT (History)
18 users (show)

See Also:

Attachments
Patch (38.88 KB, patch)
2020-10-22 06:31 PDT, Martin Robinson 		no flags Details | Formatted Diff | Diff
Patch (59.50 KB, patch)
2020-10-22 08:11 PDT, Martin Robinson 		no flags Details | Formatted Diff | Diff
Patch (79.86 KB, patch)
2020-10-22 10:30 PDT, Martin Robinson 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2020-10-22 03:43:04 PDT 
This is one part of updating the implementation of scroll-snap-margin to match the most recent CSS Scroll Snap specification. See: https://drafts.csswg.org/css-scroll-snap-1/#scroll-margin
Comment 1 Martin Robinson 2020-10-22 06:31:53 PDT 
Created attachment 412091 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-10-22 07:18:43 PDT 
Looks like you have some tests to fix.
Comment 3 Martin Robinson 2020-10-22 08:11:29 PDT 
Created attachment 412097 [details]
Patch
Comment 4 Simon Fraser (smfr) 2020-10-22 08:43:08 PDT 
Comment on attachment 412097 [details]
Patch

r=me with the caveat that if we see compat issues we might have to bring the old names back.
Comment 5 Martin Robinson 2020-10-22 09:50:42 PDT 
Thanks for the review! I guess I should mention, in case it changes your feelings about the change, that this patch maintains the old names as aliases. I will fix the failing ios test and try to land this tomorrow.
Comment 6 Martin Robinson 2020-10-22 10:30:53 PDT 
Created attachment 412112 [details]
Patch
Comment 7 EWS 2020-10-22 13:31:53 PDT 
Committed r268889: <https://trac.webkit.org/changeset/268889>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412112 [details].
Comment 8 Radar WebKit Bug Importer 2020-10-22 13:32:53 PDT 
<rdar://problem/70587063>