Bug 218073 - DFGIntegerRangeOptimization is wrong for Upsilon (as 'shadow' nodes are not in SSA form)
Summary: DFGIntegerRangeOptimization is wrong for Upsilon (as 'shadow' nodes are not i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robin Morisset
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-22 02:21 PDT by Robin Morisset
Modified: 2020-10-28 10:33 PDT (History)
7 users (show)

See Also:

Attachments
Patch (5.75 KB, patch)
2020-10-22 02:30 PDT, Robin Morisset 		no flags Details | Formatted Diff | Diff
Patch (5.75 KB, patch)
2020-10-22 02:38 PDT, Robin Morisset 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Morisset 2020-10-22 02:21:00 PDT 
rdar://problem/69823539
Comment 1 Robin Morisset 2020-10-22 02:30:10 PDT 
Created attachment 412078 [details]
Patch
Comment 2 Robin Morisset 2020-10-22 02:38:00 PDT 
Created attachment 412079 [details]
Patch

fix trivial style nit
Comment 3 Saam Barati 2020-10-28 09:48:21 PDT 
Comment on attachment 412079 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412079&action=review

> Source/JavaScriptCore/dfg/DFGIntegerRangeOptimizationPhase.cpp:1532
> +            unsigned i = 0, j = 0;

Nit: should be two lines def
Comment 4 EWS 2020-10-28 10:32:32 PDT 
Committed r269107: <https://trac.webkit.org/changeset/269107>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412079 [details].
Comment 5 Radar WebKit Bug Importer 2020-10-28 10:33:20 PDT 
<rdar://problem/70769919>