Bug 218072 – [JSC] Enable bytecode cache testing in stress tests for Linux

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Xan Lopez]

The script was only doing this for Darwin, but it can also work on Linux (possibly others, leaving that aside for now) with a trivial change.

[Xan Lopez]

Created attachment 412074 [details]
Enable bytecode cache testing on Linux, v1

[Xan Lopez]

Created attachment 412075 [details]
Enable bytecode cache testing on Linux, v2

v2, use proper indentation on the ruby script

[Xan Lopez]

Nice, this seemingly uncovers a lot of failures in bytecode cache tests for armv7 and mips (almost the same number of failures). I'll see if this also applies to x86_64 to decide what to do next.

[Xan Lopez]

(In reply to Xan Lopez from comment #3)
> Nice, this seemingly uncovers a lot of failures in bytecode cache tests for
> armv7 and mips (almost the same number of failures). I'll see if this also
> applies to x86_64 to decide what to do next.

This does not happen in x86_64, either Release or Debug.

[Xan Lopez]

Created attachment 413412 [details]
Enable bytecode cache testing on Linux, v3

v3,
do not use arrays in the shell script, that way it will work in any POSIX shell. This was the error in some of the EWS bots in the end (which use 'dash').

[Xan Lopez]

Created attachment 413579 [details]
Enable bytecode cache testing on Linux, v4

v4,
skip on MIPS until bug #218703 is fixed and we make the bots a bit faster.

[Yusuke Suzuki]

Comment on attachment 413579 [details]
Enable bytecode cache testing on Linux, v4

r=me

[EWS]

Committed r269608: <https://trac.webkit.org/changeset/269608>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413579 [details].